From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933183AbdHVPqd (ORCPT ); Tue, 22 Aug 2017 11:46:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:36824 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933001AbdHVPqc (ORCPT ); Tue, 22 Aug 2017 11:46:32 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 012672170C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Tue, 22 Aug 2017 12:46:29 -0300 From: Arnaldo Carvalho de Melo To: Konstantin Khlebnikov Cc: Peter Zijlstra , Borislav Petkov , Alexander Shishkin , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools/perf: really install manpages by make install-man Message-ID: <20170822154629.GU10891@kernel.org> References: <150322915300.129715.13645857235229756834.stgit@buzz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <150322915300.129715.13645857235229756834.stgit@buzz> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sun, Aug 20, 2017 at 02:39:13PM +0300, Konstantin Khlebnikov escreveu: > Target install-man builds them but forget to install. Thanks, applied, I guess nobody noticed that because the man pages _are_ installed when using plain 'make -C tools/perf install', as it calls 'try-install-man' and it, in turn, uses do-install-man. - Arnaldo > Signed-off-by: Konstantin Khlebnikov > --- > tools/perf/Documentation/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/Documentation/Makefile b/tools/perf/Documentation/Makefile > index 098cfb9ca8f0..db11478e30b4 100644 > --- a/tools/perf/Documentation/Makefile > +++ b/tools/perf/Documentation/Makefile > @@ -192,7 +192,7 @@ do-install-man: man > # $(INSTALL) -m 644 $(DOC_MAN5) $(DESTDIR)$(man5dir); \ > # $(INSTALL) -m 644 $(DOC_MAN7) $(DESTDIR)$(man7dir) > > -install-man: check-man-tools man > +install-man: check-man-tools man do-install-man > > ifdef missing_tools > DO_INSTALL_MAN = $(warning Please install $(missing_tools) to have the man pages installed)