* [PATCH] tools/perf: fix documentation for sysctls perf_event_paranoid and perf_event_mlock_kb
@ 2017-08-20 11:39 Konstantin Khlebnikov
2017-08-22 15:55 ` Arnaldo Carvalho de Melo
2017-08-24 8:24 ` [tip:perf/core] perf: Fix " tip-bot for Konstantin Khlebnikov
0 siblings, 2 replies; 3+ messages in thread
From: Konstantin Khlebnikov @ 2017-08-20 11:39 UTC (permalink / raw)
To: Peter Zijlstra, Alexander Shishkin, Ingo Molnar, linux-kernel,
Arnaldo Carvalho de Melo
Fix misprint CAP_IOC_LOCK -> CAP_IPC_LOCK. This capability have nothing
to do with raw tracepoints. This part is about bypassing mlock limits.
Sysctl kernel.perf_event_paranoid = -1 allows raw and ftrace function
tracepoints without CAP_SYS_ADMIN.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
---
Documentation/sysctl/kernel.txt | 13 ++++++++++++-
tools/perf/util/evsel.c | 4 +++-
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/Documentation/sysctl/kernel.txt b/Documentation/sysctl/kernel.txt
index bac23c198360..ce61d1fe08ca 100644
--- a/Documentation/sysctl/kernel.txt
+++ b/Documentation/sysctl/kernel.txt
@@ -61,6 +61,7 @@ show up in /proc/sys/kernel:
- perf_cpu_time_max_percent
- perf_event_paranoid
- perf_event_max_stack
+- perf_event_mlock_kb
- perf_event_max_contexts_per_stack
- pid_max
- powersave-nap [ PPC only ]
@@ -654,7 +655,9 @@ Controls use of the performance events system by unprivileged
users (without CAP_SYS_ADMIN). The default value is 2.
-1: Allow use of (almost) all events by all users
->=0: Disallow raw tracepoint access by users without CAP_IOC_LOCK
+ Ignore mlock limit after perf_event_mlock_kb without CAP_IPC_LOCK
+>=0: Disallow ftrace function tracepoint by users without CAP_SYS_ADMIN
+ Disallow raw tracepoint access by users without CAP_SYS_ADMIN
>=1: Disallow CPU event access by users without CAP_SYS_ADMIN
>=2: Disallow kernel profiling by users without CAP_SYS_ADMIN
@@ -673,6 +676,14 @@ The default value is 127.
==============================================================
+perf_event_mlock_kb:
+
+Control size of per-cpu ring buffer not counted agains mlock limit.
+
+The default value is 512 + 1 page
+
+==============================================================
+
perf_event_max_contexts_per_stack:
Controls maximum number of stack frame context entries for
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 413f74df08de..5ed7056d1fd0 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -2535,7 +2535,9 @@ int perf_evsel__open_strerror(struct perf_evsel *evsel, struct target *target,
"unprivileged users (without CAP_SYS_ADMIN).\n\n"
"The current value is %d:\n\n"
" -1: Allow use of (almost) all events by all users\n"
- ">= 0: Disallow raw tracepoint access by users without CAP_IOC_LOCK\n"
+ " Ignore mlock limit after perf_event_mlock_kb without CAP_IPC_LOCK\n"
+ ">= 0: Disallow ftrace function tracepoint by users without CAP_SYS_ADMIN\n"
+ " Disallow raw tracepoint access by users without CAP_SYS_ADMIN\n"
">= 1: Disallow CPU event access by users without CAP_SYS_ADMIN\n"
">= 2: Disallow kernel profiling by users without CAP_SYS_ADMIN\n\n"
"To make this setting permanent, edit /etc/sysctl.conf too, e.g.:\n\n"
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tools/perf: fix documentation for sysctls perf_event_paranoid and perf_event_mlock_kb
2017-08-20 11:39 [PATCH] tools/perf: fix documentation for sysctls perf_event_paranoid and perf_event_mlock_kb Konstantin Khlebnikov
@ 2017-08-22 15:55 ` Arnaldo Carvalho de Melo
2017-08-24 8:24 ` [tip:perf/core] perf: Fix " tip-bot for Konstantin Khlebnikov
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-08-22 15:55 UTC (permalink / raw)
To: Konstantin Khlebnikov
Cc: Peter Zijlstra, Alexander Shishkin, Ingo Molnar, linux-kernel
Em Sun, Aug 20, 2017 at 02:39:20PM +0300, Konstantin Khlebnikov escreveu:
> Fix misprint CAP_IOC_LOCK -> CAP_IPC_LOCK. This capability have nothing
> to do with raw tracepoints. This part is about bypassing mlock limits.
>
> Sysctl kernel.perf_event_paranoid = -1 allows raw and ftrace function
> tracepoints without CAP_SYS_ADMIN.
Thanks, looks sane, applied.
- Arnaldo
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> ---
> Documentation/sysctl/kernel.txt | 13 ++++++++++++-
> tools/perf/util/evsel.c | 4 +++-
> 2 files changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/sysctl/kernel.txt b/Documentation/sysctl/kernel.txt
> index bac23c198360..ce61d1fe08ca 100644
> --- a/Documentation/sysctl/kernel.txt
> +++ b/Documentation/sysctl/kernel.txt
> @@ -61,6 +61,7 @@ show up in /proc/sys/kernel:
> - perf_cpu_time_max_percent
> - perf_event_paranoid
> - perf_event_max_stack
> +- perf_event_mlock_kb
> - perf_event_max_contexts_per_stack
> - pid_max
> - powersave-nap [ PPC only ]
> @@ -654,7 +655,9 @@ Controls use of the performance events system by unprivileged
> users (without CAP_SYS_ADMIN). The default value is 2.
>
> -1: Allow use of (almost) all events by all users
> ->=0: Disallow raw tracepoint access by users without CAP_IOC_LOCK
> + Ignore mlock limit after perf_event_mlock_kb without CAP_IPC_LOCK
> +>=0: Disallow ftrace function tracepoint by users without CAP_SYS_ADMIN
> + Disallow raw tracepoint access by users without CAP_SYS_ADMIN
> >=1: Disallow CPU event access by users without CAP_SYS_ADMIN
> >=2: Disallow kernel profiling by users without CAP_SYS_ADMIN
>
> @@ -673,6 +676,14 @@ The default value is 127.
>
> ==============================================================
>
> +perf_event_mlock_kb:
> +
> +Control size of per-cpu ring buffer not counted agains mlock limit.
> +
> +The default value is 512 + 1 page
> +
> +==============================================================
> +
> perf_event_max_contexts_per_stack:
>
> Controls maximum number of stack frame context entries for
> diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
> index 413f74df08de..5ed7056d1fd0 100644
> --- a/tools/perf/util/evsel.c
> +++ b/tools/perf/util/evsel.c
> @@ -2535,7 +2535,9 @@ int perf_evsel__open_strerror(struct perf_evsel *evsel, struct target *target,
> "unprivileged users (without CAP_SYS_ADMIN).\n\n"
> "The current value is %d:\n\n"
> " -1: Allow use of (almost) all events by all users\n"
> - ">= 0: Disallow raw tracepoint access by users without CAP_IOC_LOCK\n"
> + " Ignore mlock limit after perf_event_mlock_kb without CAP_IPC_LOCK\n"
> + ">= 0: Disallow ftrace function tracepoint by users without CAP_SYS_ADMIN\n"
> + " Disallow raw tracepoint access by users without CAP_SYS_ADMIN\n"
> ">= 1: Disallow CPU event access by users without CAP_SYS_ADMIN\n"
> ">= 2: Disallow kernel profiling by users without CAP_SYS_ADMIN\n\n"
> "To make this setting permanent, edit /etc/sysctl.conf too, e.g.:\n\n"
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:perf/core] perf: Fix documentation for sysctls perf_event_paranoid and perf_event_mlock_kb
2017-08-20 11:39 [PATCH] tools/perf: fix documentation for sysctls perf_event_paranoid and perf_event_mlock_kb Konstantin Khlebnikov
2017-08-22 15:55 ` Arnaldo Carvalho de Melo
@ 2017-08-24 8:24 ` tip-bot for Konstantin Khlebnikov
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Konstantin Khlebnikov @ 2017-08-24 8:24 UTC (permalink / raw)
To: linux-tip-commits
Cc: mingo, peterz, hpa, acme, alexander.shishkin, linux-kernel,
khlebnikov, tglx
Commit-ID: ac0bb6b72f4bbab08f270a919406d971e73698b5
Gitweb: http://git.kernel.org/tip/ac0bb6b72f4bbab08f270a919406d971e73698b5
Author: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
AuthorDate: Sun, 20 Aug 2017 14:39:20 +0300
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 22 Aug 2017 13:24:54 -0300
perf: Fix documentation for sysctls perf_event_paranoid and perf_event_mlock_kb
Fix misprint CAP_IOC_LOCK -> CAP_IPC_LOCK. This capability have nothing
to do with raw tracepoints. This part is about bypassing mlock limits.
Sysctl kernel.perf_event_paranoid = -1 allows raw and ftrace function
tracepoints without CAP_SYS_ADMIN.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/150322916080.129746.11285255474738558340.stgit@buzz
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
Documentation/sysctl/kernel.txt | 13 ++++++++++++-
tools/perf/util/evsel.c | 4 +++-
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/Documentation/sysctl/kernel.txt b/Documentation/sysctl/kernel.txt
index bac23c1..ce61d1f 100644
--- a/Documentation/sysctl/kernel.txt
+++ b/Documentation/sysctl/kernel.txt
@@ -61,6 +61,7 @@ show up in /proc/sys/kernel:
- perf_cpu_time_max_percent
- perf_event_paranoid
- perf_event_max_stack
+- perf_event_mlock_kb
- perf_event_max_contexts_per_stack
- pid_max
- powersave-nap [ PPC only ]
@@ -654,7 +655,9 @@ Controls use of the performance events system by unprivileged
users (without CAP_SYS_ADMIN). The default value is 2.
-1: Allow use of (almost) all events by all users
->=0: Disallow raw tracepoint access by users without CAP_IOC_LOCK
+ Ignore mlock limit after perf_event_mlock_kb without CAP_IPC_LOCK
+>=0: Disallow ftrace function tracepoint by users without CAP_SYS_ADMIN
+ Disallow raw tracepoint access by users without CAP_SYS_ADMIN
>=1: Disallow CPU event access by users without CAP_SYS_ADMIN
>=2: Disallow kernel profiling by users without CAP_SYS_ADMIN
@@ -673,6 +676,14 @@ The default value is 127.
==============================================================
+perf_event_mlock_kb:
+
+Control size of per-cpu ring buffer not counted agains mlock limit.
+
+The default value is 512 + 1 page
+
+==============================================================
+
perf_event_max_contexts_per_stack:
Controls maximum number of stack frame context entries for
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 5dfb8bc..a5888c7 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -2674,7 +2674,9 @@ int perf_evsel__open_strerror(struct perf_evsel *evsel, struct target *target,
"unprivileged users (without CAP_SYS_ADMIN).\n\n"
"The current value is %d:\n\n"
" -1: Allow use of (almost) all events by all users\n"
- ">= 0: Disallow raw tracepoint access by users without CAP_IOC_LOCK\n"
+ " Ignore mlock limit after perf_event_mlock_kb without CAP_IPC_LOCK\n"
+ ">= 0: Disallow ftrace function tracepoint by users without CAP_SYS_ADMIN\n"
+ " Disallow raw tracepoint access by users without CAP_SYS_ADMIN\n"
">= 1: Disallow CPU event access by users without CAP_SYS_ADMIN\n"
">= 2: Disallow kernel profiling by users without CAP_SYS_ADMIN\n\n"
"To make this setting permanent, edit /etc/sysctl.conf too, e.g.:\n\n"
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-24 8:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-20 11:39 [PATCH] tools/perf: fix documentation for sysctls perf_event_paranoid and perf_event_mlock_kb Konstantin Khlebnikov
2017-08-22 15:55 ` Arnaldo Carvalho de Melo
2017-08-24 8:24 ` [tip:perf/core] perf: Fix " tip-bot for Konstantin Khlebnikov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox