From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751561AbdHVQgE (ORCPT <rfc822;w@1wt.eu>);
        Tue, 22 Aug 2017 12:36:04 -0400
Received: from bombadil.infradead.org ([65.50.211.133]:39184 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751191AbdHVQgC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 22 Aug 2017 12:36:02 -0400
Date: Tue, 22 Aug 2017 18:35:55 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Byungchul Park <byungchul.park@lge.com>, mingo@kernel.org,
        linux-kernel@vger.kernel.org, kernel-team@lge.com,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Dave Chinner <david@fromorbit.com>, Tejun Heo <tj@kernel.org>,
        johannes@sipsolutions.net
Subject: Re: [PATCH v3 1/3] lockdep: Make LOCKDEP_CROSSRELEASE configs all
 part of PROVE_LOCKING
Message-ID: <20170822163555.GG32112@worktop.programming.kicks-ass.net>
References: <20170821154600.asyzqs2zg6w6o4pg@hirez.programming.kicks-ass.net>
 <20170822051438.GD20323@X58A-UD3R>
 <20170822075238.uyfmhgxeal2bwcdg@hirez.programming.kicks-ass.net>
 <20170822085100.GH20323@X58A-UD3R>
 <20170822092141.fjmr74xhfid7vu7h@hirez.programming.kicks-ass.net>
 <20170822093337.GJ20323@X58A-UD3R>
 <20170822100840.eababgjcu76iois5@hirez.programming.kicks-ass.net>
 <20170822134922.m2g6kqsqo2eojrg7@hirez.programming.kicks-ass.net>
 <20170822144602.uh5jzkkchvdgzs3s@hirez.programming.kicks-ass.net>
 <20170822155906.GA6824@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170822155906.GA6824@redhat.com>
User-Agent: Mutt/1.5.22.1 (2013-10-16)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 22, 2017 at 05:59:06PM +0200, Oleg Nesterov wrote:
> Peter, I'll read your email tomorrow, just one note...
> 
> On 08/22, Peter Zijlstra wrote:
> >
> > Also^2, TJ, what's the purpose of using atomic_long_t for work->data?
> > All it ever seems to do is atomic_long_read() and atomic_long_set(),
> 
> plust set/clear bit, for example
> 
> 	test_and_set_bit(WORK_STRUCT_PENDING_BIT, work_data_bits(work));

Ooh, that's unintuitive. That could certainly use a comment.