From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751275AbdHVQjU (ORCPT ); Tue, 22 Aug 2017 12:39:20 -0400 Received: from verein.lst.de ([213.95.11.211]:39940 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751061AbdHVQjS (ORCPT ); Tue, 22 Aug 2017 12:39:18 -0400 Date: Tue, 22 Aug 2017 18:39:16 +0200 From: Christoph Hellwig To: David Miller Cc: hch@lst.de, mroos@linux.ee, helgaas@kernel.org, sparclinux@vger.kernel.org, linux-pci@vger.kernel.org, qla2xxx-upstream@qlogic.com, linux-kernel@vger.kernel.org Subject: Re: 4.13.0-rc4 sparc64: can't allocate MSI-X affinity masks for 2 vectors Message-ID: <20170822163916.GA31671@lst.de> References: <20170821.133549.1817020810110297960.davem@davemloft.net> <20170822063505.GA6721@lst.de> <20170822.093139.473720171751670244.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170822.093139.473720171751670244.davem@davemloft.net> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 22, 2017 at 09:31:39AM -0700, David Miller wrote: > > I fear my commit message (but not the code) might be wrong. > > irq_create_affinity_masks can return NULL any time we don't have any > > affinity masks. I've already had a discussion about this elsewhere > > with Bjorn, and I suspect we need to kill the warning or move it > > to irq_create_affinity_masks only for genuine failure cases. > > This is a rather large machine with 64 or more cpus and several NUMA > nodes. Why wouldn't there be any affinity masks available? The drivers only asked for two MSI-X vectors, and marked bost of them as pre-vectors that should not be spread. So there is no actual vector left that we want to actually spread.