From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753057AbdHWFel (ORCPT ); Wed, 23 Aug 2017 01:34:41 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34810 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931AbdHWFek (ORCPT ); Wed, 23 Aug 2017 01:34:40 -0400 Date: Tue, 22 Aug 2017 22:34:45 -0700 From: Greg Kroah-Hartman To: Shurong Zhang Cc: Jens Frederich , Daniel Drake , Jon Nettleton , devel , linux-kernel Subject: Re: [PATCH] staging: olpc_dcon: Change fixed function names with "%s: ", __func__ Message-ID: <20170823053445.GA23426@kroah.com> References: <20170823050652.GA6353@MarvinZhang.kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170823050652.GA6353@MarvinZhang.kernel@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 23, 2017 at 01:06:52PM +0800, Shurong Zhang wrote: > Replace hard-coded function names in strings with "%s", __func__ > in the olpc_dcon.c file. Issue found by checkpatch.pl. What is up with the odd indentation? And why did you send this twice? Which patch should I use? I'll just drop both, please fix up and send a v2 properly. thanks, greg k-h