From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753362AbdHWFiB (ORCPT ); Wed, 23 Aug 2017 01:38:01 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:56519 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751484AbdHWFiA (ORCPT ); Wed, 23 Aug 2017 01:38:00 -0400 X-ME-Sender: X-Sasl-enc: Hd0JJ/KE6XAbkdqFseIgqQYF0rMO2XLnf1CEJrKfcUe4 1503466679 Date: Tue, 22 Aug 2017 22:38:03 -0700 From: Greg KH To: Nick Fox Cc: arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: android: ion: Change argument to kmalloc (checkpatch) Message-ID: <20170823053803.GD23426@kroah.com> References: <20170823010450.10576-1-fox.nicholas.j@gmail.com> <20170823025537.21991-1-fox.nicholas.j@gmail.com> <20170823025537.21991-2-fox.nicholas.j@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170823025537.21991-2-fox.nicholas.j@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 22, 2017 at 10:55:37PM -0400, Nick Fox wrote: > Change argument to kmalloc() to fix style issue, reported by checkpatch > > Signed-off-by: Nick Fox > --- > drivers/staging/android/ion/ion_cma_heap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c > index b06f4cee9c7c..bb2c1449cbcf 100644 > --- a/drivers/staging/android/ion/ion_cma_heap.c > +++ b/drivers/staging/android/ion/ion_cma_heap.c > @@ -45,7 +45,7 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer, > if (!pages) > return -ENOMEM; > > - table = kmalloc(sizeof(struct sg_table), GFP_KERNEL); > + table = kmalloc(sizeof(*table), GFP_KERNEL); This doesn't apply to linux-next at all, what tree are you working against? Always work off of the correct tree please... thanks, greg k-h