From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: laurentiu.tudor@nxp.com, stuyoder@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
agraf@suse.de, ioana.ciornei@nxp.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns
Date: Tue, 22 Aug 2017 22:38:47 -0700 [thread overview]
Message-ID: <20170823053847.GF23426@kroah.com> (raw)
In-Reply-To: <1503455625.6933.12.camel@perches.com>
On Tue, Aug 22, 2017 at 07:33:45PM -0700, Joe Perches wrote:
> On Tue, 2017-08-22 at 18:40 -0700, Greg KH wrote:
> > On Thu, Aug 17, 2017 at 02:55:04PM +0300, laurentiu.tudor@nxp.com wrote:
> > > From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> > >
> > > Throughout the driver we use == 0 / != 0 to check strcmp() returns except
> > > this place, so fix it.
> >
> > You will just get someone else fixing it as it is not what checkpatch
> > recommends, so just leave it as-is please.
>
> No. That's not correct.
>
> checkpatch does not make a recommendation about
> style use with the strcmp family of functions.
Ah, ok, nevermind then...
Laurentiu, can you resend this?
thanks,
greg k-h
prev parent reply other threads:[~2017-08-23 5:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 11:55 [PATCH] staging: fsl-mc: be consistent when checking strcmp() returns laurentiu.tudor
2017-08-23 1:40 ` Greg KH
2017-08-23 2:33 ` Joe Perches
2017-08-23 5:38 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170823053847.GF23426@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=agraf@suse.de \
--cc=devel@driverdev.osuosl.org \
--cc=ioana.ciornei@nxp.com \
--cc=joe@perches.com \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stuyoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox