From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753498AbdHWHm3 (ORCPT ); Wed, 23 Aug 2017 03:42:29 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:50325 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753411AbdHWHm1 (ORCPT ); Wed, 23 Aug 2017 03:42:27 -0400 X-Originating-IP: 158.255.198.50 Date: Wed, 23 Aug 2017 09:42:18 +0200 From: jmondi To: Geert Uytterhoeven Cc: Dan Carpenter , Linus Walleij , Jacopo Mondi , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH] pinctrl: rza1: off by one in rza1_parse_gpiochip() Message-ID: <20170823074218.GA8135@w540> References: <20170818103248.ddguatdt5jhm5zx7@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, sorry for being late. With Geert's approval I guess my ack is not that necessary, but... On Wed, Aug 23, 2017 at 09:35:42AM +0200, Geert Uytterhoeven wrote: > On Fri, Aug 18, 2017 at 12:32 PM, Dan Carpenter > wrote: > > The rza1_pctl->ports[] array has RZA1_NPORTS (12) elements. The > here > > should be >= to prevent an out of bounds access. > > > > Fixes: 5a49b644b307 ("pinctrl: Renesas RZ/A1 pin and gpio controller") > > Signed-off-by: Dan Carpenter > > Reviewed-by: Geert Uytterhoeven Acked-by: Jacopo Mondi > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds