From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932240AbdHWP7D (ORCPT ); Wed, 23 Aug 2017 11:59:03 -0400 Received: from one.firstfloor.org ([193.170.194.197]:51768 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754095AbdHWP7C (ORCPT ); Wed, 23 Aug 2017 11:59:02 -0400 Date: Wed, 23 Aug 2017 08:59:00 -0700 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , Andi Kleen , peterz@infradead.org, acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Joe Mario Subject: Re: [PATCH v5 3/4] perf, tools: Add support for printing new mem_info encodings Message-ID: <20170823155900.GK2482@two.firstfloor.org> References: <20170816222156.19953-1-andi@firstfloor.org> <20170816222156.19953-4-andi@firstfloor.org> <20170823130148.GA7736@krava> <20170823140032.GE28715@tassilo.jf.intel.com> <20170823141401.GA16889@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170823141401.GA16889@krava> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > so if I find HITM with this flag set I should count it > as remote HITM then? something like attached.. untested You mean for c2c? Yes looks reasonable. -Andi > > thanks, > jirka > > --- > diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c > index 06f5a3a4295c..65e22b9e59f9 100644 > --- a/tools/perf/util/mem-events.c > +++ b/tools/perf/util/mem-events.c > @@ -279,6 +279,7 @@ int c2c_decode_stats(struct c2c_stats *stats, struct mem_info *mi) > u64 lvl = data_src->mem_lvl; > u64 snoop = data_src->mem_snoop; > u64 lock = data_src->mem_lock; > + bool mr = data_src->mem_remote; > int err = 0; > > #define HITM_INC(__f) \ > @@ -324,7 +325,7 @@ do { \ > } > > if ((lvl & P(LVL, REM_RAM1)) || > - (lvl & P(LVL, REM_RAM2))) { > + (lvl & P(LVL, REM_RAM2)) || mr) { > stats->rmt_dram++; > if (snoop & P(SNOOP, HIT)) > stats->ld_shared++; > @@ -334,7 +335,7 @@ do { \ > } > > if ((lvl & P(LVL, REM_CCE1)) || > - (lvl & P(LVL, REM_CCE2))) { > + (lvl & P(LVL, REM_CCE2)) || mr) { > if (snoop & P(SNOOP, HIT)) > stats->rmt_hit++; > else if (snoop & P(SNOOP, HITM)) >