Re: [PATCH] ASoC: rt5677: Reintroduce I2C device IDs

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1895 bytes --]

On Wed, Aug 23, 2017 at 05:29:33PM +0300, Andy Shevchenko wrote:

> On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote:
> > Not all devices with ACPI and this combination of sound devices will
> > have the required information provided via ACPI.  Reintroduce the I2C
> > device ID to restore sound functionality on on the Chromebook 'Samus'
> > model.
> 
> > This is a regression from v4.12 on my laptop (a Chromebook 'Samus'
> > that's not running ChromeOS).  My fault for getting out of the habit
> > of
> > trying -rc1 when it comes out and not spotting this sooner.  I'm not
> > 100% sure if this fix is correct for all cases as I'm only able to
> > test
> > my hardware here, and this does fix my laptop.
> 
> Are you sure the commit ddc9e69b9dc2 ("ASoC: rt5677: Hide platform data
> in the module sources") does not fix your issue?

As that's not in master yet I can't tell.  Can you give me a pointer to
somewhere?  Thanks!

> > diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
> > index 36e530a36c82..6f629278d982 100644
> > --- a/sound/soc/codecs/rt5677.c
> > +++ b/sound/soc/codecs/rt5677.c
> > @@ -5021,6 +5021,7 @@ static int rt5677_write(void *context, unsigned
> > int reg, unsigned int val)
> >  static const struct i2c_device_id rt5677_i2c_id[] = {
> >  	{ "rt5677", RT5677 },
> >  	{ "rt5676", RT5676 },
> > +	{ "RT5677CE:00", RT5677 },
> >  	{ }
> >  };
> >  MODULE_DEVICE_TABLE(i2c, rt5677_i2c_id);
> 
> This one looks weird.
> 
> The board code has this 
> 
> sound/soc/intel/boards/bdw-rt5677.c:285:                .codec_name =
> "i2c-RT5677CE:00",
> 
> It's clearly a match to ACPI enumerated I2C slave device.

I suspect that the ACPI data here is less-than-optimal (but it does have
the latest underlying chromeos update).  If you tell me what to run I
can poke the data and confirm.  Thanks!

-- 
Tom

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]