From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Shurong Zhang <zhang_shurong@foxmail.com>
Cc: Jens Frederich <jfrederich@gmail.com>,
Daniel Drake <dsd@laptop.org>,
Jon Nettleton <jon.nettleton@gmail.com>,
devel <devel@driverdev.osuosl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] staging: olpc_dcon: Change fixed function names with "%s: ", __func__
Date: Wed, 23 Aug 2017 16:21:13 -0700 [thread overview]
Message-ID: <20170823232113.GI5193@kroah.com> (raw)
In-Reply-To: <599d2f67.8b43ca0a.bef3d.273dSMTPIN_ADDED_BROKEN@mx.google.com>
On Wed, Aug 23, 2017 at 03:31:46PM +0800, Shurong Zhang wrote:
> Replace hard-coded function names in strings with "%s", __func__
> in the olpc_dcon.c file. Issue found by checkpatch.pl.
>
> Signed-off-by: Shurong Zhang <zhang_shurong@foxmail.com>
> ---
> drivers/staging/olpc_dcon/olpc_dcon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c
> index f7f3a78..3a8d99f 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.c
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.c
> @@ -456,7 +456,7 @@ static ssize_t dcon_freeze_store(struct device *dev,
> if (ret)
> return ret;
>
> - pr_info("dcon_freeze_store: %lu\n", output);
> + pr_info("%s: %lu\n", __func__, output);
Should just be deleted entirely, like Dan says.
next parent reply other threads:[~2017-08-23 23:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <599d2f67.8b43ca0a.bef3d.273dSMTPIN_ADDED_BROKEN@mx.google.com>
2017-08-23 23:21 ` Greg Kroah-Hartman [this message]
[not found] <599d2f8c.d600630a.2393.4573SMTPIN_ADDED_BROKEN@mx.google.com>
2017-08-23 11:12 ` [PATCH v2] staging: olpc_dcon: Change fixed function names with "%s: ", __func__ Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170823232113.GI5193@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=dsd@laptop.org \
--cc=jfrederich@gmail.com \
--cc=jon.nettleton@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zhang_shurong@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox