From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751414AbdHWXVJ (ORCPT ); Wed, 23 Aug 2017 19:21:09 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48202 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751038AbdHWXVI (ORCPT ); Wed, 23 Aug 2017 19:21:08 -0400 Date: Wed, 23 Aug 2017 16:21:13 -0700 From: Greg Kroah-Hartman To: Shurong Zhang Cc: Jens Frederich , Daniel Drake , Jon Nettleton , devel , linux-kernel Subject: Re: [PATCH v2] staging: olpc_dcon: Change fixed function names with "%s: ", __func__ Message-ID: <20170823232113.GI5193@kroah.com> References: <599d2f67.8b43ca0a.bef3d.273dSMTPIN_ADDED_BROKEN@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <599d2f67.8b43ca0a.bef3d.273dSMTPIN_ADDED_BROKEN@mx.google.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 23, 2017 at 03:31:46PM +0800, Shurong Zhang wrote: > Replace hard-coded function names in strings with "%s", __func__ > in the olpc_dcon.c file. Issue found by checkpatch.pl. > > Signed-off-by: Shurong Zhang > --- > drivers/staging/olpc_dcon/olpc_dcon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/olpc_dcon/olpc_dcon.c b/drivers/staging/olpc_dcon/olpc_dcon.c > index f7f3a78..3a8d99f 100644 > --- a/drivers/staging/olpc_dcon/olpc_dcon.c > +++ b/drivers/staging/olpc_dcon/olpc_dcon.c > @@ -456,7 +456,7 @@ static ssize_t dcon_freeze_store(struct device *dev, > if (ret) > return ret; > > - pr_info("dcon_freeze_store: %lu\n", output); > + pr_info("%s: %lu\n", __func__, output); Should just be deleted entirely, like Dan says.