From: Andrew Lunn <andrew@lunn.ch>
To: icenowy@aosc.io
Cc: devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-sunxi@googlegroups.com,
linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Corentin Labbe <clabbe.montjoie@gmail.com>,
Icenowy Zheng <icenowy@aosc.xyz>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/4] net: phy: realtek: add disable RX internal delay mode
Date: Thu, 24 Aug 2017 15:12:21 +0200 [thread overview]
Message-ID: <20170824131221.GA8022@lunn.ch> (raw)
In-Reply-To: <7c43220aef447e5cf21e48a9eca18535@aosc.io>
> >Do we know that the TX lines do have a delay after making this change?
> >We need to be careful here. We will get into a mess if this is
> >actually RGMII not RGMII_TXID, and somebody designs a board which
> >needs RGMII-TXID.
>
> In fact I'm not sure -- I'm even not sure that after making this change
> there's no TX delay. The change is totally not documented, so I choose
> to use a custom property in v1.
Can you get in touch with Realtek and ask? Or can you get a hardware
guy to do some measurements?
Thanks
Andrew
next prev parent reply other threads:[~2017-08-24 13:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 4:03 [PATCH v2 0/4] Workaround broken RTL8211E on some Pine64+ boards Icenowy Zheng
2017-08-22 4:03 ` [PATCH v2 1/4] net: stmmac: dwmac-sun8i: support RGMII modes with PHY internal delay Icenowy Zheng
2017-08-22 4:03 ` [PATCH v2 2/4] net: phy: realtek: change macro name for page select register Icenowy Zheng
2017-08-22 4:03 ` [PATCH v2 3/4] net: phy: realtek: add disable RX internal delay mode Icenowy Zheng
2017-08-22 13:39 ` Andrew Lunn
2017-08-24 8:05 ` icenowy
2017-08-24 13:12 ` Andrew Lunn [this message]
2017-08-24 2:35 ` kbuild test robot
2017-08-22 4:04 ` [PATCH v2 4/4] arm64: allwinner: a64: disable the RTL8211E internal RX delay on Pine64+ Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824131221.GA8022@lunn.ch \
--to=andrew@lunn.ch \
--cc=clabbe.montjoie@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=icenowy@aosc.io \
--cc=icenowy@aosc.xyz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox