From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752930AbdHXNM2 (ORCPT ); Thu, 24 Aug 2017 09:12:28 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:42906 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751349AbdHXNM1 (ORCPT ); Thu, 24 Aug 2017 09:12:27 -0400 Date: Thu, 24 Aug 2017 15:12:21 +0200 From: Andrew Lunn To: icenowy@aosc.io Cc: devicetree@vger.kernel.org, Florian Fainelli , netdev@vger.kernel.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Chen-Yu Tsai , Corentin Labbe , Icenowy Zheng , Maxime Ripard , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/4] net: phy: realtek: add disable RX internal delay mode Message-ID: <20170824131221.GA8022@lunn.ch> References: <20170822040400.12166-1-icenowy@aosc.io> <20170822040400.12166-4-icenowy@aosc.io> <20170822133906.GG24555@lunn.ch> <7c43220aef447e5cf21e48a9eca18535@aosc.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7c43220aef447e5cf21e48a9eca18535@aosc.io> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >Do we know that the TX lines do have a delay after making this change? > >We need to be careful here. We will get into a mess if this is > >actually RGMII not RGMII_TXID, and somebody designs a board which > >needs RGMII-TXID. > > In fact I'm not sure -- I'm even not sure that after making this change > there's no TX delay. The change is totally not documented, so I choose > to use a custom property in v1. Can you get in touch with Realtek and ask? Or can you get a hardware guy to do some measurements? Thanks Andrew