From: msuchanek <msuchanek@suse.de>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Jonathan Corbet <corbet@lwn.net>, Jessica Yu <jeyu@kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Jason Baron <jbaron@akamai.com>,
Hari Bathini <hbathini@linux.vnet.ibm.com>,
Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com>,
Daniel Axtens <dja@axtens.net>,
Andrew Morton <akpm@linux-foundation.org>,
Thiago Jung Bauermann <bauerman@linux.vnet.ibm.com>,
Balbir Singh <bsingharora@gmail.com>,
Nicholas Piggin <npiggin@gmail.com>,
Michael Neuling <mikey@neuling.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Christophe Leroy <christophe.leroy@c-s.fr>,
Scott Wood <oss@buserror.net>,
"Oliver O'Halloran" <oohall@gmail.com>,
David Howells <dhowells@redhat.com>,
"Sylvain 'ythier' Hitier" <sylvain.hitier@gmail.com>,
Ingo Molnar <mingo@kernel.org>, Kees Cook <keescook@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Steven Rostedt\," <rostedt@goodmis.org>,
Viresh Kumar <viresh.kumar@linaro.org>, Tejun Heo <tj@kernel.org>,
Lokesh Vutla <lokeshvutla@ti.com>, Baoquan He <bhe@redhat.com>,
Ilya Matveychikov <matvejchikov@gmail.com>,
linuxppc-dev@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 4/4] boot/param: add pointer to next argument to unknown parameter callback
Date: Thu, 24 Aug 2017 14:17:39 +0200 [thread overview]
Message-ID: <20170824141739.190826e4@naga> (raw)
In-Reply-To: <87shghusz0.fsf@concordia.ellerman.id.au>
On Thu, 24 Aug 2017 21:04:51 +1000
Michael Ellerman <mpe@ellerman.id.au> wrote:
> Michal Suchanek <msuchanek@suse.de> writes:
>
> > The fadump parameter processing re-does the logic of next_arg quote
> > stripping to determine where the argument ends. Pass pointer to the
> > next argument instead to make this more robust.
> >
> > Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> > ---
> > arch/powerpc/kernel/fadump.c | 13 +++++--------
> > arch/powerpc/mm/hugetlbpage.c | 4 ++--
> > include/linux/moduleparam.h | 2 +-
> > init/main.c | 12 ++++++------
> > kernel/module.c | 4 ++--
> > kernel/params.c | 19 +++++++++++--------
> > lib/dynamic_debug.c | 2 +-
> > 7 files changed, 28 insertions(+), 28 deletions(-)
>
> Can you split out a patch that adds the next argument and updates the
> callers. And then a patch for the fadump to use the new arg.
>
> cheers
Yes, that makes sense.
Thanks
Michal
next prev parent reply other threads:[~2017-08-24 12:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 20:14 [PATCH v7 1/4] powerpc/fadump: reduce memory consumption for capture kernel Michal Suchanek
2017-08-17 20:14 ` [PATCH v7 2/4] powerpc/fadump: update documentation about 'fadump_extra_args=' parameter Michal Suchanek
2017-08-17 20:14 ` [PATCH v7 3/4] lib/cmdline.c Remove quotes symmetrically Michal Suchanek
2017-08-17 21:27 ` msuchanek
2017-08-21 10:27 ` Baoquan He
2017-08-21 11:30 ` Michal Suchánek
2017-08-24 11:02 ` Michael Ellerman
2017-08-24 12:15 ` msuchanek
2017-08-17 20:14 ` [PATCH v7 4/4] boot/param: add pointer to next argument to unknown parameter callback Michal Suchanek
2017-08-24 11:04 ` Michael Ellerman
2017-08-24 12:17 ` msuchanek [this message]
2017-08-18 10:50 ` [PATCH v7 1/4] powerpc/fadump: reduce memory consumption for capture kernel Hari Bathini
2017-08-18 11:57 ` Michal Suchánek
2017-08-18 14:00 ` Hari Bathini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824141739.190826e4@naga \
--to=msuchanek@suse.de \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=bauerman@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bhe@redhat.com \
--cc=bsingharora@gmail.com \
--cc=christophe.leroy@c-s.fr \
--cc=corbet@lwn.net \
--cc=dhowells@redhat.com \
--cc=dja@axtens.net \
--cc=hbathini@linux.vnet.ibm.com \
--cc=jbaron@akamai.com \
--cc=jeyu@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lokeshvutla@ti.com \
--cc=mahesh@linux.vnet.ibm.com \
--cc=matvejchikov@gmail.com \
--cc=mikey@neuling.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=oohall@gmail.com \
--cc=oss@buserror.net \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=sylvain.hitier@gmail.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox