public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: kys@exchange.microsoft.com, Haiyang Zhang <haiyangz@microsoft.com>
Cc: kys@microsoft.com, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
	olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com,
	jasowang@redhat.com, leann.ogasawara@canonical.com,
	marcelo.cerri@canonical.com, sthemmin@microsoft.com
Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix rescind handling issues
Date: Thu, 24 Aug 2017 15:41:02 -0700	[thread overview]
Message-ID: <20170824154102.62a02190@xeon-e3> (raw)
In-Reply-To: <1502471039-5281-1-git-send-email-kys@exchange.microsoft.com>

On Fri, 11 Aug 2017 10:03:59 -0700
kys@exchange.microsoft.com wrote:

> From: K. Y. Srinivasan <kys@microsoft.com>
> 
> This patch handles the following issues that were observed when we are
> handling racing channel offer message and rescind message for the same
> offer:
> 
> 1. Since the host does not respond to messages on a rescinded channel,
> in the current code, we could be indefinitely blocked on the vmbus_open() call.
> 
> 2. When a rescinded channel is being closed, if there is a pending interrupt on the
> channel, we could end up freeing the channel that the interrupt handler would run on.
> 
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Reviewed-by: Dexuan Cui <decui@microsoft.com>
> Tested-by: Dexuan Cui <decui@microsoft.com>

This patch breaks re-initialization of the network device on MTU changes.

Doing:
	# ip li set dev eth1 mtu 9000

will hang in rndis_filter_add waiting for subchannel notification.
This is likely because when the vmbus device is reopened the sub channels
are not correctly created.  Not sure what is wrong with the patch, but my
suspicion is that the close/rescind events are no longer being sent to the
host.

  reply	other threads:[~2017-08-24 22:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-11 17:03 [PATCH 1/1] Drivers: hv: vmbus: Fix rescind handling issues kys
2017-08-24 22:41 ` Stephen Hemminger [this message]
2017-09-15 13:42   ` Vitaly Kuznetsov
2017-09-15 13:48     ` Vitaly Kuznetsov
2017-09-15 18:01       ` KY Srinivasan
     [not found]         ` <CAOaVG15SSUemaWuuCXz3O=3S2jCW+3=1Jdp1Ff8P+za9TFerRA@mail.gmail.com>
2017-09-18  8:31           ` Vitaly Kuznetsov
2017-09-18 12:55             ` Vitaly Kuznetsov
2017-09-18 23:18               ` KY Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170824154102.62a02190@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=apw@canonical.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=haiyangz@microsoft.com \
    --cc=jasowang@redhat.com \
    --cc=kys@exchange.microsoft.com \
    --cc=kys@microsoft.com \
    --cc=leann.ogasawara@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.cerri@canonical.com \
    --cc=olaf@aepfle.de \
    --cc=sthemmin@microsoft.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox