From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753946AbdHXQa3 (ORCPT ); Thu, 24 Aug 2017 12:30:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54104 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753755AbdHXQ1n (ORCPT ); Thu, 24 Aug 2017 12:27:43 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 2F18A7EA98 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=none smtp.mailfrom=jolsa@kernel.org DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 2F18A7EA98 From: Jiri Olsa To: Arnaldo Carvalho de Melo , Peter Zijlstra Cc: lkml , Ingo Molnar , Alexander Shishkin , Namhyung Kim , David Ahern , Andi Kleen , Mark Rutland Subject: [PATCH 01/10] perf/x86: Add warning on proper cpu during event's update Date: Thu, 24 Aug 2017 18:27:28 +0200 Message-Id: <20170824162737.7813-2-jolsa@kernel.org> In-Reply-To: <20170824162737.7813-1-jolsa@kernel.org> References: <20170824162737.7813-1-jolsa@kernel.org> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 24 Aug 2017 16:27:43 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mark reported that we could actually call pmu->read on unscheduled event. I think it's good idea to keep a warning here to see if we've get it wrong again in future. Reported-by: Mark Rutland Signed-off-by: Jiri Olsa --- arch/x86/events/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c index af12e294caed..b8e394d9f7f2 100644 --- a/arch/x86/events/core.c +++ b/arch/x86/events/core.c @@ -72,6 +72,8 @@ u64 x86_perf_event_update(struct perf_event *event) int idx = hwc->idx; u64 delta; + WARN_ON_ONCE(event->oncpu != smp_processor_id()); + if (idx == INTEL_PMC_IDX_FIXED_BTS) return 0; -- 2.9.5