From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753898AbdHXQpd (ORCPT ); Thu, 24 Aug 2017 12:45:33 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:38532 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753470AbdHXQpa (ORCPT ); Thu, 24 Aug 2017 12:45:30 -0400 Date: Thu, 24 Aug 2017 09:45:24 -0700 From: Tejun Heo To: Waiman Long Cc: Li Zefan , Johannes Weiner , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpuset: Fix incorrect memory_pressure control file mapping Message-ID: <20170824164524.GR491396@devbig577.frc2.facebook.com> References: <1503590669-16601-1-git-send-email-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1503590669-16601-1-git-send-email-longman@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 24, 2017 at 12:04:29PM -0400, Waiman Long wrote: > The memory_pressure control file was incorrectly set up without > a private value (0, by default). As a result, this control > file was treated like memory_migrate on read. By adding back the > FILE_MEMORY_PRESSURE private value, the correct memory pressure value > will be returned. > > Signed-off-by: Waiman Long Oops, applied to cgroup/for-4.13-fixes w/ stable cc'd. I broke it way back in v4.4 which makes me wonder whether anybody is actually using it. Thanks a lot for catching it. -- tejun