From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753788AbdHXUwB (ORCPT <rfc822;w@1wt.eu>);
        Thu, 24 Aug 2017 16:52:01 -0400
Received: from one.firstfloor.org ([193.170.194.197]:40362 "EHLO
        one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753201AbdHXUwA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 24 Aug 2017 16:52:00 -0400
Date: Thu, 24 Aug 2017 13:51:59 -0700
From: Andi Kleen <andi@firstfloor.org>
To: Aaron Lindsay <alindsay@codeaurora.org>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
        Digant Desai <digantd@codeaurora.org>, timur@codeaurora.org
Subject: Re: [PATCH] perf stat: Add event-interval-print option
Message-ID: <20170824205158.GM2482@two.firstfloor.org>
References: <1502896117-19420-1-git-send-email-alindsay@codeaurora.org>
 <20170824203902.GA5620@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170824203902.GA5620@codeaurora.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 24, 2017 at 04:39:02PM -0400, Aaron Lindsay wrote:
> Does anyone have any feedback on this patch or the idea in general?
> 
> Also, (for our bookkeeping - not trying to rush things) is there any
> chance this will still make it in for the 4.14 merge window, or is it
> 4.15 material at the earliest?

You can already do that with leader sampling through perf record

e.g. 

% perf record -e '{cpu/cpu-cycles,period=10000/,branches,branch-misses}:S' ...

% perf script
   swapper     0 [005] 3905226.804037:      10210 cpu/cpu-cycles,period=10000/:  ffffffff9e87643c intel_idle ([kernel.kallsyms])
         swapper     0 [005] 3905226.804037:        345                     branches:  ffffffff9e87643c intel_idle ([kernel.kallsyms])
         swapper     0 [005] 3905226.804037:         58                branch-misses:  ffffffff9e87643c intel_idle ([kernel.kallsyms])
          :16797 16797 [004] 3905226.804038:      10160 cpu/cpu-cycles,period=10000/:  ffffffffc07fdd10 kvm_fetch_guest_virt ([kvm])
          :16797 16797 [004] 3905226.804038:        515                     branches:  ffffffffc07fdd10 kvm_fetch_guest_virt ([kvm])
          :16797 16797 [004] 3905226.804038:         19                branch-misses:  ffffffffc07fdd10 kvm_fetch_guest_virt ([kvm])

Yes it's a useful technique.

-Andi