public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Arnd Bergmann <arnd@arndb.de>,
	devel@driverdev.osuosl.org,
	Yan-Hsuan Chuang <yhchuang@realtek.com>,
	linux-kernel@vger.kernel.org, Birming Chiu <birming@realtek.com>,
	Steven Ting <steventing@realtek.com>
Subject: Re: [PATCH 2/3] staging: rtlwifi: add MAC80211 dependency
Date: Thu, 24 Aug 2017 16:59:05 -0700	[thread overview]
Message-ID: <20170824235905.GA23042@kroah.com> (raw)
In-Reply-To: <b1d99a9d-8f88-5599-8334-6441549ed0a7@lwfinger.net>

On Thu, Aug 24, 2017 at 02:23:08PM -0500, Larry Finger wrote:
> On 08/23/2017 08:22 AM, Arnd Bergmann wrote:
> > Like the version in drivers/net/wireless, this driver requires the
> > MAC80211 framework, otherwise we run into a link error:
> > 
> > ERROR: "ieee80211_rx_irqsafe" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> > ERROR: "cfg80211_unlink_bss" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> > ERROR: "ieee80211_beacon_get_tim" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> > ERROR: "ieee80211_resume_disconnect" [drivers/staging/rtlwifi/r8822be.ko] undefined!
> > 
> > This adds the Kconfig dependency for it.
> > 
> > Fixes: 56bde846304e ("staging: r8822be: Add existing rtlwifi and rtl_pci parts for new driver")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Greg,
> 
> I lost track of which version of this patch you are taking. The one that
> Randy Dunlap sent that added NETDEVICES was better than the initial version,
> but this one with MAC80211 is the correct one. Randy's patch is in the
> latest pull I did on staging.
> 
> Do you want an updated patch?

Nope, all should be good now, I've fixed it by hand.  Look in my tree
and if it's still wrong there, please send me a fixup.

thanks,

greg k-h

  reply	other threads:[~2017-08-24 23:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170823132337.517466-1-arnd@arndb.de>
2017-08-23 13:22 ` [PATCH 2/3] staging: rtlwifi: add MAC80211 dependency Arnd Bergmann
2017-08-23 15:44   ` Randy Dunlap
2017-08-23 23:19     ` Greg Kroah-Hartman
2017-08-23 23:29       ` Greg Kroah-Hartman
2017-08-24 19:23   ` Larry Finger
2017-08-24 23:59     ` Greg Kroah-Hartman [this message]
2017-08-23 13:22 ` [PATCH 3/3] staging: rtlwifi: simplify logical operation Arnd Bergmann
2017-08-24 19:06   ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170824235905.GA23042@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=arnd@arndb.de \
    --cc=birming@realtek.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=steventing@realtek.com \
    --cc=yhchuang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox