From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754187AbdHYATe (ORCPT ); Thu, 24 Aug 2017 20:19:34 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:43358 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753837AbdHYATd (ORCPT ); Thu, 24 Aug 2017 20:19:33 -0400 Date: Thu, 24 Aug 2017 17:19:36 -0700 From: Greg KH To: Jisheng Zhang Cc: arve@android.com, riandrews@android.com, john.stultz@linaro.org, devel@driverdev.osuosl.org, robh@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] binder: allow ANDROID_BINDER_IPC_32BIT to be unselected on 32bit ARM Message-ID: <20170825001936.GA4811@kroah.com> References: <20170824024928.707-1-jszhang@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170824024928.707-1-jszhang@marvell.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 24, 2017 at 10:49:28AM +0800, Jisheng Zhang wrote: > As noted in commit d0bdff0db809 ("staging: Fix build issues with new > binder API"), we can add back the choice for 32bit ARM "once a 64bit > __get_user_asm_* implementation is merged." Commit e38361d032f1 ("ARM: > 8091/2: add get_user() support for 8 byte types") has added the > support, so it's time to allow ANDROID_BINDER_IPC_32BIT to be > unselected on 32bit ARM so that the 64bit ABI can be tested/used on > 32bit systems. > > This change allows running the same 32bit userspace build no matter > the kernel is 64bit or 32bit. > > Signed-off-by: Jisheng Zhang > --- > Since v1: > - fix the commit msg > > drivers/android/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/android/Kconfig b/drivers/android/Kconfig > index 832e885349b1..aca5dc30b97b 100644 > --- a/drivers/android/Kconfig > +++ b/drivers/android/Kconfig > @@ -32,7 +32,7 @@ config ANDROID_BINDER_DEVICES > therefore logically separated from the other devices. > > config ANDROID_BINDER_IPC_32BIT > - bool > + bool "Use old (Android 4.4 and earlier) 32-bit binder API" Again, your changelog text does not match up with what this patch does at all, please fix something... greg k-h