Re: [PATCH v4 0/4] PCI: rockchip: Move PCIE_WAKE handling into rockchip pcie driver

Bjorn Helgaas
2017-08-24T16:55:09Z

On Tue, Aug 22, 2017 at 11:19:30AM +0800, Jeffy Chen wrote:
>
> Currently we are handling pcie wake in mrvl wifi driver. But Brian
> suggests to move it into rockchip pcie driver.
>
> Tested on my chromebook bob(with cros 4.4 kernel and mrvl wifi).
>
>
> Changes in v4:
> Rebase on newest for-next branch, also fix error handling by:
> 1e7f570a1b86 PCI: rockchip: Idle inactive PHY(s)
>
> Changes in v3:
> Fix error handling
>
> Changes in v2:
> Use dev_pm_set_dedicated_wake_irq
> -- Suggested by Brian Norris <briannorris@chromium.com>
>
> Jeffy Chen (4):
> PCI: rockchip: Fix error handlings
> PCI: rockchip: Add support for pcie wake irq
> dt-bindings: PCI: rockchip: Add support for pcie wake irq
> arm64: dts: rockchip: Handle pcie wake in pcie driver for Gru
>
> .../devicetree/bindings/pci/rockchip-pcie.txt | 20 ++-
> arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 15 +-
> drivers/pci/host/pcie-rockchip.c | 179 ++++++++++++---------
> 3 files changed, 126 insertions(+), 88 deletions(-)

Looking for acks from Shawn and Rob...

And I'm not sure about the DT wake IRQ description. That seems like it
could potentially be generic than this Rockchip-specific proposal.