From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Andreas Noever <andreas.noever@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Yehezkel Bernat <yehezkel.bernat@intel.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Colin King <colin.king@canonical.com>
Subject: Re: [PATCH resend] thunderbolt: Fix reset response_type
Date: Sun, 27 Aug 2017 16:38:17 +0300 [thread overview]
Message-ID: <20170827133817.GD2980@lahna.fi.intel.com> (raw)
In-Reply-To: <20170816085417.7xlnl54jkx2p36qs@mwanda>
On Wed, Aug 16, 2017 at 11:54:17AM +0300, Dan Carpenter wrote:
> There is a mistake here where we accidentally use sizeof(TB_CFG_PKG_RESET)
> instead of just TB_CFG_PKG_RESET. The size of an int is 4 so it's the
> same as TB_CFG_PKG_NOTIFY_ACK.
>
> Fixes: d7f781bfdbf4 ("thunderbolt: Rework control channel to be more reliable")
> Reported-by: Colin King <colin.king@canonical.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> Resending with Greg CC'd. This was also:
> Signed-off-by: Andreas Noever <andreas.noever@gmail.com>
> But I wasn't sure if I should add that tag.
Hi Greg,
Can you pick this fix to your char-misc tree?
Thanks!
next prev parent reply other threads:[~2017-08-27 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 14:31 [PATCH] thunderbolt: fix incorrect value assigned to req->response_type Colin King
2017-08-15 14:38 ` Mika Westerberg
2017-08-15 15:22 ` Dan Carpenter
2017-08-15 15:46 ` Colin Ian King
2017-08-16 8:54 ` [PATCH resend] thunderbolt: Fix reset response_type Dan Carpenter
2017-08-27 13:38 ` Mika Westerberg [this message]
2017-08-16 8:10 ` [PATCH] thunderbolt: fix incorrect value assigned to req->response_type Mika Westerberg
2017-08-16 16:13 ` Greg Kroah-Hartman
2017-08-17 9:39 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170827133817.GD2980@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andreas.noever@gmail.com \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=yehezkel.bernat@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox