From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Badhri Jagan Sridharan <badhri@google.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] staging: usb: typec: tcpm set port type callback
Date: Sun, 27 Aug 2017 20:01:36 +0200 [thread overview]
Message-ID: <20170827180136.GA30883@kroah.com> (raw)
In-Reply-To: <20170827052324.11854-1-Badhri@google.com>
On Sat, Aug 26, 2017 at 10:23:24PM -0700, Badhri Jagan Sridharan wrote:
> The port type callback call enquires the tcpc_dev if
> the requested port type is supported. If supported, then
> performs a tcpm reset if required after setting the tcpm
> internal port_type variable.
>
> Check against the tcpm port_type instead of checking
> against caps.type as port_type reflects the current
> configuration.
>
> Signed-off-by: Badhri Jagan Sridharan <Badhri@google.com>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/staging/typec/tcpm.c | 52 ++++++++++++++++++++++++++++++++++----------
> 1 file changed, 41 insertions(+), 11 deletions(-)
This series is really messed up. I see patches out of 6 and out of 11,
and none of it "threaded" so I don't know what is what to apply :(
Please resend the whole series, correctly, with Guenter's reviewed-by,
so I know what to apply and in what order.
thanks,
greg k-h
next prev parent reply other threads:[~2017-08-27 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-27 5:23 [PATCH 1/6] staging: usb: typec: tcpm set port type callback Badhri Jagan Sridharan
2017-08-27 17:20 ` Guenter Roeck
2017-08-27 18:01 ` Greg Kroah-Hartman [this message]
2017-08-27 18:16 ` Guenter Roeck
2017-08-28 16:55 ` Badhri Jagan Sridharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170827180136.GA30883@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=badhri@google.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox