From: Stephen Hemminger <stephen@networkplumber.org>
To: Eduardo Otubo <otubo@redhat.com>
Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCHv2] hv_set_ifconfig.sh double check before setting ip
Date: Mon, 28 Aug 2017 08:16:24 -0700 [thread overview]
Message-ID: <20170828081624.16a1e4de@xeon-e3> (raw)
In-Reply-To: <20170828100121.17321-1-otubo@redhat.com>
On Mon, 28 Aug 2017 12:01:21 +0200
Eduardo Otubo <otubo@redhat.com> wrote:
> v2: The script is now a little bit safer so it doesn't conflicts with
> network daemon trying to set configurations at the same time.
>
> This patch fixes the behavior of the hv_set_ifconfig script when setting
> the interface ip. Sometimes the interface has already been configured by
> network daemon, in this case hv_set_ifconfig causes "RTNETLINK: file
> exists error"; in order to avoid this error this patch makes sure double
> checks the interface before trying anything.
>
> Signed-off-by: Eduardo Otubo <otubo@redhat.com>
Adding new dependency on systemd is not going to make this script
even less useful. I wonder why the script still exists at all? Most of the
Linux distro's can already setup HV networking without it.
next prev parent reply other threads:[~2017-08-28 15:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 10:01 [PATCHv2] hv_set_ifconfig.sh double check before setting ip Eduardo Otubo
2017-08-28 13:47 ` Olaf Hering
2017-08-28 15:16 ` Stephen Hemminger [this message]
2017-08-28 15:56 ` Haiyang Zhang
2017-08-28 16:05 ` Eduardo Otubo
2017-08-28 16:48 ` KY Srinivasan
2017-08-31 8:16 ` Eduardo Otubo
2017-08-31 20:21 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170828081624.16a1e4de@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=otubo@redhat.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox