From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752090AbdH1JT0 (ORCPT ); Mon, 28 Aug 2017 05:19:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36694 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751888AbdH1JTX (ORCPT ); Mon, 28 Aug 2017 05:19:23 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D01D27E421 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Mon, 28 Aug 2017 11:19:21 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH v2 14/19] perf, tools, stat: Support JSON metrics in perf stat Message-ID: <20170828091920.GB4948@krava> References: <20170811232634.30465-1-andi@firstfloor.org> <20170811232634.30465-14-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170811232634.30465-14-andi@firstfloor.org> User-Agent: Mutt/1.8.3 (2017-05-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 28 Aug 2017 09:19:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 11, 2017 at 04:26:29PM -0700, Andi Kleen wrote: > From: Andi Kleen > > Add generic support for standalone metrics specified in JSON files > to perf stat. A metric is a formula that uses multiple events > to compute a higher level result (e.g. IPC). > > Previously metrics were always tied to an event and automatically > enabled with that event. But now change it that we can have > standalone metrics. They are in the same JSON data structure > as events, but don't have an event name. > > We also allow to organize the metrics in metric groups, which > allows a short cut to select several related metrics at once. > > Add a new -M / --metrics option to perf stat that adds the metrics > or metric groups specified. > > Add the core code to manage and parse the metric groups. They > are collected from the JSON data structures into a separate rblist. > When computing shadow values look for metrics in that list. > Then they are computed using the existing saved values infrastructure > in stat-shadow.c > > The actual JSON metrics are in a separate pull request. would need this for testing.. could you please put it somewhere? thanks, jirka