From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751422AbdH1LHL (ORCPT ); Mon, 28 Aug 2017 07:07:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51078 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751161AbdH1LHJ (ORCPT ); Mon, 28 Aug 2017 07:07:09 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7274880467 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jolsa@redhat.com Date: Mon, 28 Aug 2017 13:07:06 +0200 From: Jiri Olsa To: Zhou Chengming Cc: peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, acme@kernel.org, rostedt@goodmis.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, huawei.libin@huawei.com Subject: Re: [PATCH] perf/ftrace: fix doubled traces of perf on ftrace:function Message-ID: <20170828110706.GA17767@krava> References: <1503668977-12526-1-git-send-email-zhouchengming1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1503668977-12526-1-git-send-email-zhouchengming1@huawei.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 28 Aug 2017 11:07:09 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 25, 2017 at 09:49:37PM +0800, Zhou Chengming wrote: SNIP > diff --git a/kernel/trace/trace_event_perf.c b/kernel/trace/trace_event_perf.c > index 562fa69..70c5025 100644 > --- a/kernel/trace/trace_event_perf.c > +++ b/kernel/trace/trace_event_perf.c > @@ -306,6 +306,7 @@ void perf_trace_buf_update(void *record, u16 type) > perf_ftrace_function_call(unsigned long ip, unsigned long parent_ip, > struct ftrace_ops *ops, struct pt_regs *pt_regs) > { > + struct perf_event *event; > struct ftrace_entry *entry; > struct hlist_head *head; > struct pt_regs regs; > @@ -329,8 +330,9 @@ void perf_trace_buf_update(void *record, u16 type) > > entry->ip = ip; > entry->parent_ip = parent_ip; > + event = container_of(ops, struct perf_event, ftrace_ops); nit, white space at the end of the line ^^^ but the change looks good to me Reviewed-by: Jiri Olsa thanks, jirka