From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751419AbdH1Olp (ORCPT ); Mon, 28 Aug 2017 10:41:45 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45248 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170AbdH1Olo (ORCPT ); Mon, 28 Aug 2017 10:41:44 -0400 Date: Mon, 28 Aug 2017 16:41:49 +0200 From: Greg KH To: Bartlomiej Zolnierkiewicz Cc: Michal Januszewski , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fbdev: uvesafb: remove DRIVER_ATTR() usage Message-ID: <20170828144149.GA28860@kroah.com> References: <20170719125119.GB17776@kroah.com> <3613878.J9SAsAfrTp@amdc3058> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3613878.J9SAsAfrTp@amdc3058> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 01, 2017 at 03:36:01PM +0200, Bartlomiej Zolnierkiewicz wrote: > On Wednesday, July 19, 2017 02:51:19 PM Greg KH wrote: > > From: Greg Kroah-Hartman > > > > It's better to be explicit and use the DRIVER_ATTR_RW() macro when > > defining a driver's sysfs file. Bonus is this fixes up a checkpatch.pl > > warning. > > > > This is part of a series to drop DRIVER_ATTR() from the tree entirely. > > > > Cc: Michal Januszewski > > Cc: Bartlomiej Zolnierkiewicz > > Signed-off-by: Greg Kroah-Hartman > > Acked-by: Bartlomiej Zolnierkiewicz > > I assume that this will go through your tree with other DRIVER_ATTR() > removal patches (please ping me if you want me to merge this patch > through fbdev tree). I'll take it through mine, thanks. greg k-h