From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751453AbdH1Pf0 (ORCPT ); Mon, 28 Aug 2017 11:35:26 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51270 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbdH1PfZ (ORCPT ); Mon, 28 Aug 2017 11:35:25 -0400 Date: Mon, 28 Aug 2017 17:35:30 +0200 From: Greg KH To: quochuybk2010@gmail.com Cc: fancer.lancer@gmail.com, linux-kernel@vger.kernel.org, Huy Duong Subject: Re: [PATCH v2] eeprom: idt_89hpesx: Support both ACPI and OF probing Message-ID: <20170828153530.GA25019@kroah.com> References: <20170808115721.GA26426@mobilestation> <1502248126-18177-1-git-send-email-quochuybk2010@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502248126-18177-1-git-send-email-quochuybk2010@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 09, 2017 at 10:08:46AM +0700, quochuybk2010@gmail.com wrote: > From: Huy Duong > > Allow the idt_89hpesx driver to get information from child nodes from > both OF and ACPI by using more generic fwnode_property_read*() functions. > > Below is an example of instantiating idt_89hpesx driver via ACPI Table: > > Device(IDT0) { > Name(_HID, "PRP0001") > Name(_CID, "PRP0001") > Name(_CCA, ONE) > Name(_STR, Unicode("IDT SW I2C Slave")) > Name(_CRS, ResourceTemplate () { > I2cSerialBus (0x74, ControllerInitiated, 1000, > AddressingMode7Bit, "\\_SB.I2CS", > 0x00, ResourceConsumer, , > ) > }) > Name (_DSD, Package () { > ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), > Package () { > Package () {"compatible", "idt,89hpes32nt8ag2"}, > }, > }) > Device (EPR0) { > Name (_DSD, Package () { > ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), > Package () { > Package () {"compatible", "onsemi,24c64"}, > Package () {"reg", 0x50}, > } > }) > } > } > > Signed-off-by: Huy Duong > Acked-by: Serge Semin > --- > Changes in v2: > * Replace with > * Change eeprom_addr to u32 to avoid type casting Doesn't apply to my tree at all. Can you rebase it against char-misc.git on the char-misc-next branch and resend? thanks, greg k-h