From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751507AbdH1Qrk (ORCPT ); Mon, 28 Aug 2017 12:47:40 -0400 Received: from one.firstfloor.org ([193.170.194.197]:58146 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751218AbdH1Qrj (ORCPT ); Mon, 28 Aug 2017 12:47:39 -0400 Date: Mon, 28 Aug 2017 09:47:38 -0700 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH v2 17/19] perf, tools, stat: Support duration_time for metrics Message-ID: <20170828164738.GP2482@two.firstfloor.org> References: <20170811232634.30465-1-andi@firstfloor.org> <20170811232634.30465-17-andi@firstfloor.org> <20170828091931.GD4948@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170828091931.GD4948@krava> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 28, 2017 at 11:19:31AM +0200, Jiri Olsa wrote: > On Fri, Aug 11, 2017 at 04:26:32PM -0700, Andi Kleen wrote: > > From: Andi Kleen > > > > Some of the metrics formulas (like GFLOPs) need to know how long > > the measurement period is. Support an internal event called duration_time, which > > reports time in second. It maps to the dummy event, but is > > special cased for statistics to report the walltime duration. > > > > So far it is not printed, but only used internally for metrics. > > > > Signed-off-by: Andi Kleen > > --- > > tools/perf/util/parse-events.l | 1 + > > tools/perf/util/stat-shadow.c | 17 +++++++++++++---- > > 2 files changed, 14 insertions(+), 4 deletions(-) > > > > diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l > > index fdb5bb52f01f..ea2426daf7e8 100644 > > --- a/tools/perf/util/parse-events.l > > +++ b/tools/perf/util/parse-events.l > > @@ -288,6 +288,7 @@ cpu-migrations|migrations { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COU > > alignment-faults { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COUNT_SW_ALIGNMENT_FAULTS); } > > emulation-faults { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COUNT_SW_EMULATION_FAULTS); } > > dummy { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COUNT_SW_DUMMY); } > > +duration_time { return sym(yyscanner, PERF_TYPE_SOFTWARE, PERF_COUNT_SW_DUMMY); } > > could you please use '-' (current style) instead of '_' This would require escaping in the expressions because - is a vaid operator. It looks nicer with the _ and it's only used internally anyways. -Andi