Re: [GIT PULL] workqueue fixes for v4.13-rc3

Geert Uytterhoeven
2017-08-24T13:32:48Z

Hi Tejun,

On Wed, Aug 23, 2017 at 7:08 PM, Tejun Heo <tj@kernel.org> wrote:
> On Wed, Aug 23, 2017 at 04:47:41PM +0200, Geert Uytterhoeven wrote:
>> Some code is mixing up multiple memory nodes with multiple cpu nodes.
>> M68k uses DISCONTIGMEM, but not NUMA (no SMP):
>>
>> config NEED_MULTIPLE_NODES
>> def_bool y
>> depends on DISCONTIGMEM || NUMA
>>
>> The (virtual) Atari has 2 memory nodes:
>> - node0: start 0x00000000 size 0x00e00000
>> - node1: start 0x01000000 size 0x10000000
>> Both are tied to the same (single) CPU node, of course.
>
> Ah, okay, so it has multiple nodes but not NUMA. The generic numa
> topology code assumes that there's only one node if !NUMA and reports
> all online cpus regardless of the node number, which makes the same
> CPUs to be reported for all nodes on the system. I think something
> like the following (completely untested) should work.

Thank you, that got rid of the warning.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds