Re: [GIT PULL] workqueue fixes for v4.13-rc3

Tejun Heo
2017-08-07T17:07:04Z

Hello,

On Mon, Aug 07, 2017 at 02:18:51PM +0200, Geert Uytterhoeven wrote:
> This triggers on m68k, which doesn't have SMP.
> Haven't tried it yet on any other system due to holidays.

That's weird. Can you please apply the following patch and report the
messages?

Thanks.

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index ca937b0..1b9d21b 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -3579,8 +3579,10 @@ static bool wq_calc_node_cpumask(const struct workqueue_attrs *attrs, int node,
cpumask_and(cpumask, attrs->cpumask, wq_numa_possible_cpumask[node]);

if (cpumask_empty(cpumask)) {
- pr_warn_once("WARNING: workqueue cpumask: online intersect > "
- "possible intersect\n");
+ pr_warn_once("WARNING: workqueue empty cpumask: node=%d cpu_going_down=%d cpumask=%*pb online=%*pb possible=%*pb\n",
+ node, cpu_going_down, cpumask_pr_args(attrs->cpumask),
+ cpumask_pr_args(cpumask_of_node(node)),
+ cpumask_pr_args(wq_numa_possible_cpumask[node]));
return false;
}

@@ -5526,6 +5528,9 @@ static void __init wq_numa_init(void)

wq_numa_possible_cpumask = tbl;
wq_numa_enabled = true;
+
+ for_each_node(node)
+ printk("XXX wq node[%d] %*pb\n", node, cpumask_pr_args(wq_numa_possible_cpumask[node]));
}

/**