From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751249AbdH2GX2 (ORCPT ); Tue, 29 Aug 2017 02:23:28 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33918 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbdH2GX1 (ORCPT ); Tue, 29 Aug 2017 02:23:27 -0400 Date: Tue, 29 Aug 2017 08:23:32 +0200 From: Greg KH To: Jonathan Whitaker Cc: devel@driverdev.osuosl.org, sayli karnik , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: ks7010: Fix hardcoded function names in strings. Warnings reported by checkpatch.pl. Message-ID: <20170829062332.GA29080@kroah.com> References: <1503963162-3810-1-git-send-email-jon.b.whitaker@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1503963162-3810-1-git-send-email-jon.b.whitaker@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 28, 2017 at 05:32:39PM -0600, Jonathan Whitaker wrote: > This commit replaces hardcoded function name strings to the more preferred '"%s...", __func__' > style. These warnings were reported by checkpatch.pl. Please wrap your changelog text at 72 columns. And your subject is very odd, please fix that up as well. > > Signed-off-by: Jonathan Whitaker > --- > drivers/staging/ks7010/ks7010_sdio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c > index 9b28ee1..c0e91c3 100644 > --- a/drivers/staging/ks7010/ks7010_sdio.c > +++ b/drivers/staging/ks7010/ks7010_sdio.c > @@ -834,7 +834,7 @@ static int ks7010_sdio_probe(struct sdio_func *func, > unsigned char byte; > int ret; > > - DPRINTK(5, "ks7010_sdio_probe()\n"); > + DPRINTK(5, "%s()\n", __func__); > > priv = NULL; > netdev = NULL; > @@ -1008,7 +1008,7 @@ static void ks7010_sdio_remove(struct sdio_func *func) > struct ks_sdio_card *card; > struct ks_wlan_private *priv; > > - DPRINTK(1, "ks7010_sdio_remove()\n"); > + DPRINTK(1, "%s()\n", __func__); These lines can just be deleted entirely, we have in-kernel functionality for tracing kernel function calls, no need to have special debug lines just for that. thanks, greg k-h