Re: [PATCH net-next] staging: irda: force to be a kernel module

Greg KH
2017-08-29T17:31:25Z

On Tue, Aug 29, 2017 at 07:26:08PM +0200, Greg KH wrote:
> On Tue, Aug 29, 2017 at 09:35:07AM -0700, David Miller wrote:
> > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Date: Tue, 29 Aug 2017 11:14:17 +0200
> >
> > > Now that the IRDA networking code has moved into drivers/staging/, the
> > > link order is changed for when it is initialized if built into the
> > > system. This can cause a crash when initializing as the netfilter core
> > > hasn't been initialized yet.
> > >
> > > So force the IRDA code to be built as a module, preventing the crash.
> > >
> > > Reported-by: kernel test robot <fengguang.wu@intel.com>
> > > Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
> >
> > I don't think this is reasonable.
> >
> > IRDA being built in was broken by moving it to staging, so it's a
> > regression and we should find a way to fix it.
>
> Hm, this is due to netlink coming before irda in the link order before
> this patch series. I can't change the link order to put all of net/
> before drivers/, which would solve this, and I don't think I can put:
> obj-$(CONFIG_IRDA) += ../../drivers/staging/irda/net/
> in a networking Makefile, can I? Does "../" even work in a Makefile
> like that?

Wait, I think that does work, let me go test this some more...

thanks,

greg k-h-