From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: driverdevel <devel@driverdev.osuosl.org>,
Samuel Ortiz <samuel@sortiz.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Stefano Brivio <sbrivio@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 0/4] irda: move it to drivers/staging so we can delete it
Date: Tue, 29 Aug 2017 16:48:50 +0200 [thread overview]
Message-ID: <20170829144850.GC22532@kroah.com> (raw)
In-Reply-To: <CAMuHMdVb-oygJkkHwBOfSmNECAfF72QruJSmVTpqdUW+RNJbrg@mail.gmail.com>
On Tue, Aug 29, 2017 at 02:11:39PM +0200, Geert Uytterhoeven wrote:
> Hi Greg,
>
> On Tue, Aug 29, 2017 at 1:28 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Tue, Aug 29, 2017 at 01:11:31PM +0200, Stefano Brivio wrote:
> >> On Tue, 29 Aug 2017 12:59:00 +0200
> >> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >> > On Sun, Aug 27, 2017 at 5:03 PM, Greg Kroah-Hartman
> >> > <gregkh@linuxfoundation.org> wrote:
> >> > > The IRDA code has long been obsolete and broken. So, to keep people
> >> > > from trying to use it, and to prevent people from having to maintain it,
> >> > > let's move it to drivers/staging/ so that we can delete it entirely from
> >> > > the kernel in a few releases.
> >> >
> >> > (diving into an early boot crash)
> >> >
> >> > Have you tried running this? ;-)
> >> >
> >> > irda_init() and net_dev_init() are both subsys_initcall()s.
> >> > But the former now runs before the latter, leading to:
> >> >
> >> > Unable to handle kernel NULL pointer dereference at virtual address 00000004
> >>
> >> Should be fixed by https://patchwork.ozlabs.org/patch/807006/
> >> ("[net-next] staging: irda: force to be a kernel module") I guess...
> >
> > Yup, that's the fix for this issue.
> >
> > Geert, does that fix the problem for you?
>
> Thanks, that patch fixes the crash, obviously.
>
> It does mean you can no longer have IrDA in a non-modular kernel.
Given that irda doesn't really work, I doubt anyone is going to care
about it :)
thanks,
greg k-h
next prev parent reply other threads:[~2017-08-29 14:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-27 15:03 [PATCH 0/4] irda: move it to drivers/staging so we can delete it Greg Kroah-Hartman
2017-08-27 15:03 ` [PATCH 1/4] irda: move net/irda/ to drivers/staging/irda/net/ Greg Kroah-Hartman
2017-08-30 6:04 ` [lkp-robot] [irda] 66d98e78e4: BUG:unable_to_handle_kernel kernel test robot
2017-08-30 6:12 ` Greg Kroah-Hartman
2017-08-30 6:19 ` Ye Xiaolong
2017-08-27 15:03 ` [PATCH 2/4] irda: move drivers/net/irda to drivers/staging/irda/drivers Greg Kroah-Hartman
2017-08-27 15:03 ` [PATCH 3/4] irda: move include/net/irda into staging subdirectory Greg Kroah-Hartman
2017-08-27 15:03 ` [PATCH 4/4] staging: irda: add a TODO file Greg Kroah-Hartman
2017-08-27 15:35 ` [PATCH 0/4] irda: move it to drivers/staging so we can delete it Joe Perches
2017-08-27 16:13 ` Greg Kroah-Hartman
2017-08-27 16:19 ` Joe Perches
2017-08-27 16:53 ` Greg Kroah-Hartman
2017-08-27 23:15 ` Joe Perches
2017-08-28 23:42 ` David Miller
2017-08-28 23:46 ` Joe Perches
2017-08-29 5:06 ` Greg KH
2017-08-29 21:32 ` Ondrej Zary
2017-08-31 4:30 ` Greg KH
2017-08-31 7:31 ` Ondrej Zary
2017-08-29 10:59 ` Geert Uytterhoeven
2017-08-29 11:11 ` Stefano Brivio
2017-08-29 11:28 ` Greg Kroah-Hartman
2017-08-29 12:11 ` Geert Uytterhoeven
2017-08-29 14:48 ` Greg Kroah-Hartman [this message]
2017-08-29 16:49 ` David Miller
2017-08-29 16:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829144850.GC22532@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=samuel@sortiz.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox