From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752525AbdH2Pmn (ORCPT ); Tue, 29 Aug 2017 11:42:43 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:38100 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751343AbdH2Pmk (ORCPT ); Tue, 29 Aug 2017 11:42:40 -0400 Date: Tue, 29 Aug 2017 08:42:36 -0700 From: Tejun Heo To: Waiman Long Cc: Peter Zijlstra , lizefan@huawei.com, hannes@cmpxchg.org, mingo@redhat.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, pjt@google.com, luto@amacapital.net, efault@gmx.de, torvalds@linux-foundation.org, guro@fb.com Subject: Re: [PATCH 3/3] cgroup: Implement cgroup2 basic CPU usage accounting Message-ID: <20170829154236.GQ491396@devbig577.frc2.facebook.com> References: <20170811163754.3939102-1-tj@kernel.org> <20170811163754.3939102-4-tj@kernel.org> <20170829143252.6zoes63bwfflukjy@hirez.programming.kicks-ass.net> <20170829152426.GL491396@devbig577.frc2.facebook.com> <02e84780-1ad7-95e3-345e-baec3dc6db84@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <02e84780-1ad7-95e3-345e-baec3dc6db84@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Waiman. On Tue, Aug 29, 2017 at 11:32:35AM -0400, Waiman Long wrote: > > Also, please note that a system may end up with a lot of cgroups > > without the user intending to. memcg drains removed cgroups lazily > > and the number of draining cgroups can reach very high numbers if the > > system isn't under memory pressure. The plan is to add basic stats > > for other resources too and keeping it scalable w.r.t. idle cgroups > > allows using the same mechanism for all resources. > > I think it will be good to put the rationale behind this function as a > comment in the code. Ah, good point. I'll beef up the overall comment in the header file and point to that from the function comment. Thanks. -- tejun