From: Tejun Heo <tj@kernel.org>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: David Ahern <dsahern@gmail.com>, Christoph Hellwig <hch@lst.de>,
linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Robert Elliott <elliott@hpe.com>
Subject: Re: boot failure with 4.13.0-rc6 due to ATA errors
Date: Tue, 29 Aug 2017 08:55:05 -0700 [thread overview]
Message-ID: <20170829155505.GR491396@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20170829155102.vgbzyh7fhjrurdhl@khazad-dum.debian.net>
Hello, Henrique.
On Tue, Aug 29, 2017 at 12:51:02PM -0300, Henrique de Moraes Holschuh wrote:
> > > > ATA-8 and later mirrors the TRUSTED COMPUTING SUPPORTED bit in word 48 of
> > > > the IDENTIFY DEVICE data. Check this before issuing a READ LOG PAGE
> > > > command to avoid issues with buggy devices. The only downside is that
> > > > we can't support Security Send / Receive for a device with an older
> > > > revision due to the conflicting use of this field in earlier
> > > > specifications.
> >
> > Christoph, I'm gonna revert the horkage patch and apply this one. If
> > you can think of a better way to do this, please let me know.
>
> The one thing that comes to mind would be an additional patch to allow
> people with ATA-7 to bypass the identify device data, and rely just on
> the read log page check, based on a kernel command line parameter.
>
> If we get enough sucessful reports to make it worth it, an whitelist
> could be added...
If the ones we miss are the ones based on old revisions, does it
matter? If we have to, we can just whitelist those devices and I
don't expect there to be many.
Thanks.
--
tejun
next prev parent reply other threads:[~2017-08-29 15:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-28 18:40 boot failure with 4.13.0-rc6 due to ATA errors David Ahern
2017-08-28 19:59 ` Tejun Heo
2017-08-28 20:26 ` David Ahern
2017-08-28 21:22 ` Tejun Heo
2017-08-29 12:42 ` Christoph Hellwig
2017-08-29 14:27 ` Tejun Heo
2017-08-29 15:08 ` David Ahern
2017-08-29 15:30 ` Tejun Heo
2017-08-29 15:51 ` Henrique de Moraes Holschuh
2017-08-29 15:55 ` Tejun Heo [this message]
2017-08-29 16:02 ` Henrique de Moraes Holschuh
2017-08-29 15:38 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829155505.GR491396@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=dsahern@gmail.com \
--cc=elliott@hpe.com \
--cc=hch@lst.de \
--cc=hmh@hmh.eng.br \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox