From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751623AbdH2TE7 (ORCPT ); Tue, 29 Aug 2017 15:04:59 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37286 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751186AbdH2TE6 (ORCPT ); Tue, 29 Aug 2017 15:04:58 -0400 Date: Tue, 29 Aug 2017 21:05:03 +0200 From: Greg KH To: David Miller Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org, samuel@sortiz.org, linux-kernel@vger.kernel.org, fengguang.wu@intel.com, geert@linux-m68k.org Subject: Re: [PATCH v2 net-next] irda: fix link order if IRDA is built into the kernel Message-ID: <20170829190503.GA31452@kroah.com> References: <20170829172608.GA4700@kroah.com> <20170829173129.GA11029@kroah.com> <20170829174622.GA25926@kroah.com> <20170829.104945.1786969849973428586.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170829.104945.1786969849973428586.davem@davemloft.net> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 29, 2017 at 10:49:45AM -0700, David Miller wrote: > From: Greg KH > Date: Tue, 29 Aug 2017 19:46:22 +0200 > > > When moving the IRDA code out of net/ into drivers/staging/irda/net, the > > link order changes when IRDA is built into the kernel. That causes a > > kernel crash at boot time as netfilter isn't initialized yet. > > > > To fix this, build and link the irda networking code in the same exact > > order that it was previously before the move. > > > > Reported-by: kernel test robot > > Reported-by: Geert Uytterhoeven > > Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org > > Greg, just change the initializer in IRDA so that it will run > after subsys_init() when built statically. > > IRDA is definitely not the first pontentially statically built > thing that needs netlink up and available. Ok, will do that tomorrow and test it and send you the patch. thanks, greg k-h