From: Dan Carpenter <dan.carpenter@oracle.com>
To: harsha <harshasharmaiitr@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG()
Date: Tue, 29 Aug 2017 23:36:08 +0300 [thread overview]
Message-ID: <20170829203608.mdstdicxgpidps64@mwanda> (raw)
In-Reply-To: <1504034462-13195-1-git-send-email-harshasharmaiitr@gmail.com>
On Wed, Aug 30, 2017 at 12:51:01AM +0530, harsha wrote:
> Hi,
> harsha, this is my real name.
That's your full name that you use to sign legal documents? No last
name? No capital letter at the beginning?
> There is no need to call BUG() over here as this error is not very basic and BUG() tends to bring the system down so calling WARN_ON() is preferable.
In the original code the kernel will call BUG() once but in the new code
it will spam the dmesg forever until you pull the power cord. There is
no improvement.
regards,
dan carpenter
next prev parent reply other threads:[~2017-08-29 20:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 19:21 [PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG() harsha
2017-08-29 19:21 ` harsha
2017-08-30 5:58 ` Greg KH
2017-08-29 20:36 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-08-29 18:00 harsha
2017-08-29 18:07 ` Greg KH
2017-08-29 17:19 harsha
2017-08-29 17:28 ` Greg KH
2017-09-01 9:07 ` kbuild test robot
2017-09-01 9:11 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829203608.mdstdicxgpidps64@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=harshasharmaiitr@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox