public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	corbet@lwn.net, Andrew Morton <akpm@osdl.org>,
	linux-leds@vger.kernel.org
Subject: Re: [PATCH] Documentation: small fixes for LEDs, hide notes about vibration
Date: Tue, 29 Aug 2017 22:38:46 +0200	[thread overview]
Message-ID: <20170829203846.GB21650@amd> (raw)
In-Reply-To: <991f8a29-75b7-891d-cd33-a1e50f91e67d@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]

Hi!

> > -As a specific example of this use-case, let's look at vibrate feature on
> > -phones. Vibrate function on phones is implemented using PWM pins on SoC or
> > -PMIC. There is a need to activate one shot timer to control the vibrate
> > -feature, to prevent user space crashes leaving the phone in vibrate mode
> > -permanently causing the battery to drain.
> 
> I'm not sure if it is a good idea to remove this description. Users will
> still be able to use transient trigger this way. It has been around for
> five years already and there are users which employ it in this
> particular way [0].

I am. Yes, people were doing that, but no, vibration motor is not a
LED. PWM behaviour is different, for example, motor is likely to stop
at low PWM values. We do not want people to do that.

> Apart from that it's the only documented kernel API for vibrate devices
> AFAICT.

Input subsystem has force-feedback protocol, which is very often just
vibrations. Documentation/input/ff.rst . Nokia N900 phone actually
uses that API.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2017-08-29 20:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-28  9:50 [PATCH] Documentation: small fixes for LEDs, hide notes about vibration Pavel Machek
2017-08-29 19:47 ` Jacek Anaszewski
2017-08-29 20:38   ` Pavel Machek [this message]
2017-08-30 20:44     ` Jacek Anaszewski
2017-08-31  8:09       ` Pavel Machek
2017-08-31 20:17         ` Jacek Anaszewski
2017-08-31 22:22           ` Rob Herring
2017-08-31  7:52     ` Jani Nikula
2017-08-31  8:05       ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170829203846.GB21650@amd \
    --to=pavel@ucw.cz \
    --cc=akpm@osdl.org \
    --cc=corbet@lwn.net \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox