public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sherry Yang <sherryy@android.com>
Cc: linux-kernel@vger.kernel.org,
	"open list:ANDROID DRIVERS" <devel@driverdev.osuosl.org>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Riley Andrews" <riandrews@android.com>,
	maco@google.com, tkjos@google.com
Subject: Re: [PATCH v3 1/6] android: binder: Refactor prev and next buffer into a helper function
Date: Wed, 30 Aug 2017 08:07:43 +0200	[thread overview]
Message-ID: <20170830060743.GC3035@kroah.com> (raw)
In-Reply-To: <20170830004702.120371-2-sherryy@android.com>

On Tue, Aug 29, 2017 at 05:46:57PM -0700, Sherry Yang wrote:
> Use helper functions buffer_next and buffer_prev instead
> of list_entry to get the next and previous buffers.
> 
> Signed-off-by: Sherry Yang <sherryy@android.com>
> ---
>  drivers/android/binder_alloc.c | 24 +++++++++++++++---------
>  1 file changed, 15 insertions(+), 9 deletions(-)

What changed from the previous version?

Always put the changes below the --- line.  Like the documentation says
to do so.

Also, don't I already have these patches in my tree?  Do you want me to
revert the existing ones and use the new ones, or what about a fixup
patch for any differences?

confused,

greg k-h

  reply	other threads:[~2017-08-30  6:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30  0:46 [PATCH 0/6] android: binder: move allocator metadata and add shrinker Sherry Yang
2017-08-30  0:46 ` [PATCH v3 1/6] android: binder: Refactor prev and next buffer into a helper function Sherry Yang
2017-08-30  6:07   ` Greg Kroah-Hartman [this message]
2017-08-30 19:46     ` Sherry Yang
2017-08-30 20:08       ` Dan Carpenter
2017-08-31  4:28       ` Greg Kroah-Hartman
2017-08-31 17:26         ` [PATCH] android: binder: fixup crash introduced by moving buffer hdr Sherry Yang
2017-09-01  6:52           ` Greg KH
2017-08-31 17:30         ` [PATCH v3 1/6] android: binder: Refactor prev and next buffer into a helper function Sherry Yang
2017-08-31 18:47           ` Greg Kroah-Hartman
2017-08-31 18:56             ` [PATCH] android: binder: Add page usage in binder stats Sherry Yang
2017-08-30  0:46 ` [PATCH v3 2/6] android: binder: Add allocator selftest Sherry Yang
2017-08-30  0:46 ` [PATCH v3 3/6] android: binder: Move buffer out of area shared with user space Sherry Yang
2017-08-30  9:29   ` Dan Carpenter
2017-08-30 20:04     ` Arve Hjønnevåg
2017-08-30 20:20       ` Dan Carpenter
2017-08-30 21:03         ` Todd Kjos
2017-08-30  0:47 ` [PATCH v3 4/6] android: binder: Add global lru shrinker to binder Sherry Yang
2017-08-30  0:47 ` [PATCH v3 5/6] android: binder: Add shrinker tracepoints Sherry Yang
2017-08-30  0:47 ` [PATCH v3 6/6] android: binder: Add page usage in binder stats Sherry Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170830060743.GC3035@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arve@android.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maco@google.com \
    --cc=riandrews@android.com \
    --cc=sherryy@android.com \
    --cc=tkjos@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox