From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751419AbdH3JHC (ORCPT ); Wed, 30 Aug 2017 05:07:02 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:50930 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751298AbdH3JHA (ORCPT ); Wed, 30 Aug 2017 05:07:00 -0400 Date: Wed, 30 Aug 2017 11:06:59 +0200 From: Pavel Machek To: Andrey Smirnov Cc: Greg Kroah-Hartman , linux-kernel , Chris Healy , Lucas Stach , Nikita Yushchenko , Lee Jones Subject: Re: [PATCH v5 1/2] platform: Add driver for RAVE Supervisory Processor Message-ID: <20170830090658.GA31423@amd> References: <20170728142704.11156-1-andrew.smirnov@gmail.com> <20170728142704.11156-2-andrew.smirnov@gmail.com> <20170824160416.GB22743@xo-6d-61-c0.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TB36FDmn/VVEgNH/" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --TB36FDmn/VVEgNH/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2017-08-28 09:23:10, Andrey Smirnov wrote: > On Thu, Aug 24, 2017 at 9:04 AM, Pavel Machek wrote: > > On Fri 2017-07-28 07:27:03, Andrey Smirnov wrote: > >> Add a driver for RAVE Supervisory Processor, an MCU implementing > >> varoius bits of housekeeping functionality (watchdoging, backlight > >> control, LED control, etc) on RAVE family of products by Zodiac > >> Inflight Innovations. > >> > >> This driver implementes core MFD/serdev device as well as > >> communication subroutines necessary for commanding the device. > > > > This introduces new /sysfs userland interfaces, right? That needs docum= enting, > > and some review. > > >=20 > Correct and yes, good point. I was originally asked to implement all > of the exposed attributes via sysfs, but, after more discussion, I now > have green light to move a large chunk of those into debugfs which is > what I intend to do in v6, I'll also update it to document all of the > remaining sysfs entries. Ok, we still would like to have documentation. .. and debugfs is for debugging, not for production use. > > For example... bootreason is there on Nokia N900, too. We want to use s= ame interface... > > >=20 > I tried grepping Documentation/ABI and kernel tree in general for that > sysfs interface, but wasn't able to find it. If you don't mind, could > you point me to where it's implemented? I'm not sure if the implementation is in the mainline, but the bootloader provides this functionality. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --TB36FDmn/VVEgNH/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlmmgDIACgkQMOfwapXb+vLesACgh2vxTJY9QClM2na/hirnQGWi vk8An01wCVgKqoGshMfn/z6bpIWhyRuN =SDzW -----END PGP SIGNATURE----- --TB36FDmn/VVEgNH/--