From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751843AbdH3OZv (ORCPT ); Wed, 30 Aug 2017 10:25:51 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52172 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751409AbdH3OZs (ORCPT ); Wed, 30 Aug 2017 10:25:48 -0400 Date: Wed, 30 Aug 2017 16:25:51 +0200 From: "gregkh@linuxfoundation.org" To: "Bernat, Yehezkel" Cc: "mika.westerberg@linux.intel.com" , "andreas.noever@gmail.com" , "andriy.shevchenko@linux.intel.com" , "Jamet, Michael" , "lukas@wunner.de" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/3] thunderbolt: Remove superfluous check Message-ID: <20170830142551.GA18731@kroah.com> References: <29cf6caa-07a9-9c52-bd8c-6634749f99ca@intel.com> <20170815070228.GG2369@lahna.fi.intel.com> <20170827133127.GC2980@lahna.fi.intel.com> <20170828142030.GA23672@kroah.com> <1504101658.2677.25.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1504101658.2677.25.camel@intel.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 30, 2017 at 02:00:53PM +0000, Bernat, Yehezkel wrote: > On Mon, 2017-08-28 at 16:20 +0200, Greg Kroah-Hartman wrote: > > On Sun, Aug 27, 2017 at 04:31:27PM +0300, Mika Westerberg wrote: > > > > > > On Tue, Aug 15, 2017 at 10:02:28AM +0300, Mika Westerberg wrote: > > > > > > > > On Tue, Aug 15, 2017 at 08:19:01AM +0300, Bernat, Yehezkel wrote: > > > > > > > > > > The key size is tested by hex2bin() already (as '\0' isn't an > > > > > hex digit) > > > > > > > > > > Suggested-by: Andy Shevchenko > > > > > Signed-off-by: Yehezkel Bernat > > > > Acked-by: Mika Westerberg > > > Hi Greg, > > > > > > Do you have any comments regarding these patches? If not could you > > > take > > > them to your char-misc tree? > > Will do, thanks. > > > > greg k-h > > Hi Greg, > > I'm not sure if you intended to do so anyway, but I think it worth > adding to v4.13, as these are fixes (and somewhat security related). I didn't intend to, it's a bit late for 4.13, if you think these should be backported, let stable@vger.kernel.org know the git commit ids when they land in Linus's tree, and I'll be glad to backport them. thanks, greg k-h