From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751284AbdH3UiV (ORCPT ); Wed, 30 Aug 2017 16:38:21 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:43663 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750890AbdH3UiU (ORCPT ); Wed, 30 Aug 2017 16:38:20 -0400 Date: Wed, 30 Aug 2017 22:38:17 +0200 From: Pavel Machek To: Andrey Smirnov Cc: linux-kernel , Chris Healy , Lucas Stach , Nikita Yushchenko , Lee Jones , Greg Kroah-Hartman Subject: Re: [PATCH v6 1/2] platform: Add driver for RAVE Supervisory Processor Message-ID: <20170830203817.GA15462@amd> References: <20170828163131.24815-1-andrew.smirnov@gmail.com> <20170828163131.24815-2-andrew.smirnov@gmail.com> <20170830105515.GA4926@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fdj2RfSjLxBAspz7" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fdj2RfSjLxBAspz7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >> + * 9 -> Illegal Trap > >> + * 10 -> Unknown > >> + * 11 -> Crew Panel Requested > > > > Anyway... If you move management chip to .. I don't know, i2c, the > > path would change. Also it would be different path on N900. Userland > > should not have to deal with this. > > > > And... this should really be string, as the list will need to grow on > > different hardware. >=20 > I think we have a misunderstanding, with this part of the patch set I > am not trying to propose a generic ABI that would be useful for any > other driver but this one. Hence the lack of concern for different Yes, but sorry, that's no-go. Kernel should hide differences between different machiens, and it should be rather easy in this case. > hardware paths (it's not going to change for this device) and device > specific codes instead of generic strings. I can see how my choice of > generic name such as "reset_reason" might suggest that, so I apologize > for any confusion I might have caused. If said generic name is > unacceptable I can change it to "rave_reset_reason" or something > similar and if that is undesirable as well I am happy to drop this > part of the patch and re-visit this later. Ok, can we do the re-visit thing? You may want to contact these people: Date: Wed, 30 Aug 2017 12:59:55 +0200 =46rom: Pavel Machek To: Vadim Pasternak Cc: lee.jones@linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org, j.anaszewski@samsung.com, rpurdie@rpsys.net, linux-leds@vger.kernel.org, jiri@resnulli.us, gregkh@linuxfoundation.org, platform-driver-x86@vger.kernel.org Subject: Re: [patch v4 1/2] mfd: Add Mellanox regmap core driver They are currently trying to add driver, including > Cause of reset nodes: > - cpu_kernel_panic > - cpu_shutdown > - bmc_warm_reset =2E..which sounds very similar to what you are doing. =09 > > Plus we'll really need better explanations. What is difference between > > "normal power off" and "host requested"? > > >=20 > Short answer: I don't know, since this is as much information that ICD > for that device gave me. >=20 > Long answer: It probably can be discerned from the source code of the > firmware/schematic as well as by bothering the right people, but since > I get a feeling that this attribute is not really desirable in its > current from, I'll punt doing that. Ok. > >> + The following values are valid: > >> + * 0 -> SD card > >> + * 1 -> eMMC > >> + * 2 -> SPI NOR > >> + > >> + NOTE: Setting boot source on RDU1 hardware is > >> + currently not implemented > > > > Same comments apply here. >=20 > Yep, same comment for me as well :-) Ok :-). Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --fdj2RfSjLxBAspz7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlmnIjkACgkQMOfwapXb+vJNcwCggtrHl9kF+13OgfYLWhNlD0oz T7wAnAnXi18t4HI6LNQOMepzy8GK3dtf =Ddjs -----END PGP SIGNATURE----- --fdj2RfSjLxBAspz7--