From: Tony Lindgren <tony@atomide.com>
To: Timur Tabi <timur@codeaurora.org>,
Linus Walleij <linus.walleij@linaro.org>,
Grygorii Strashko <grygorii.strashko@ti.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Regression in next with gpiolib
Date: Wed, 30 Aug 2017 14:41:28 -0700 [thread overview]
Message-ID: <20170830214127.GJ6008@atomide.com> (raw)
Hi Timur, Linus & Grygorii,
Looks like commit 108d23e322a2 ("gpiolib: request the gpio before
querying its direction") caused a regression on at least pandaboard
es with booting hanging shortly after gpio init.
It seems to be that we're now calling request and free on all gpios
before they are properly configured?
I narrowed the hang down to gpio bank1 lines 7 and possibly 8 where
not calling omap_gpio_free() on them makes the system boot again.
These lines are used for the leds in omap4-panda-common.dtsi, and
omap_gpio_free() will by default set the unused lines for input
and bad things happen. I guess hardware failure could also happen
although I have not seen it here.
It seems a similar issue can exist on other platforms too,
so it's probably a good idea to revert this for now.
Any ideas on how we should fix this?
Regards,
Tony
next reply other threads:[~2017-08-30 21:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 21:41 Tony Lindgren [this message]
2017-08-30 21:49 ` Regression in next with gpiolib Timur Tabi
2017-08-31 5:59 ` Linus Walleij
2017-08-31 14:02 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830214127.GJ6008@atomide.com \
--to=tony@atomide.com \
--cc=grygorii.strashko@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox