From: Tejun Heo <tj@kernel.org>
To: Neeraj Upadhyay <neeraju@codeaurora.org>
Cc: lizefan@huawei.com, mingo@kernel.org, longman@redhat.com,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
sramana@codeaurora.org, prsood@codeaurora.org
Subject: Re: [PATCH] cgroup: Fix potential race between cgroup_exit and cpuset_attach
Date: Wed, 30 Aug 2017 18:10:24 -0700 [thread overview]
Message-ID: <20170831011024.GC491396@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <1504097630-32690-1-git-send-email-neeraju@codeaurora.org>
Hello,
On Wed, Aug 30, 2017 at 06:23:50PM +0530, Neeraj Upadhyay wrote:
> cpuset_hotplug_workfn()
> cgroup_transfer_tasks()
> cgroup_migrate()
> cgroup_migrate_execute()
> <TASK EXIT>
> list_del_init(&task->cg_list)
> cpuset_attach()
> cgroup_taskset_first(tset, &css) // css is not set
> guarantee_online_mems(cs, ...) // data abort
I don't think this can happen anymore. We lock out task exits during
migration and don't call migration callbacks if there's no tasks to
migrate.
Thanks.
--
tejun
prev parent reply other threads:[~2017-08-31 1:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 12:53 [PATCH] cgroup: Fix potential race between cgroup_exit and cpuset_attach Neeraj Upadhyay
2017-08-31 1:10 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831011024.GC491396@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=longman@redhat.com \
--cc=mingo@kernel.org \
--cc=neeraju@codeaurora.org \
--cc=prsood@codeaurora.org \
--cc=sramana@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox