Re: [OpenRISC] [PATCH 01/13] openrisc: use shadow registers to save regs on exception

Stafford Horne
2017-09-01T08:26:15Z

On Fri, Sep 01, 2017 at 10:03:44AM +0200, Geert Uytterhoeven wrote:
> On Fri, Sep 1, 2017 at 10:02 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
> > On Wed, Aug 30, 2017 at 11:58 PM, Stafford Horne <shorne@gmail.com> wrote:
> >> --- a/arch/openrisc/Kconfig
> >> +++ b/arch/openrisc/Kconfig
> >> @@ -121,6 +121,16 @@ config OPENRISC_NO_SPR_SR_DSX
> >> Say N here if you know that your OpenRISC processor has
> >> SPR_SR_DSX bit implemented. Say Y if you are unsure.
> >>
> >> +config OPENRISC_HAVE_SHADOW_GPRS
> >> + bool "Support for shadow gpr files"
> >
> > default y if SMP?
>
> Oops, that's not sufficient.
>
> bool "Support for shadow gpr files" if !SMP
> default y if SMP

Thanks yes, the help text says its mandatory. That should be forced as you
showed.

-Stafford

> >> + help
> >> + Say Y here if your OpenRISC processor features shadowed
> >> + register files. They will in such case be used as a
> >> + scratch reg storage on exception entry.
> >> +
> >> + On SMP systems, this feature is mandatory.
> >> + On a unicore system it's safe to say N here if you are unsure.
> >> +
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds