From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: Brian Norris <computersforpeace@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
David Woodhouse <dwmw2@infradead.org>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 0/2] mtd: nand: fix regression introduced by splitting off manufacturer dependent code
Date: Thu, 31 Aug 2017 13:18:36 +0200 [thread overview]
Message-ID: <20170831131836.777aa652@bbrezillon> (raw)
In-Reply-To: <1504001833-18097-1-git-send-email-LW@KARO-electronics.de>
On Tue, 29 Aug 2017 12:17:11 +0200
Lothar Waßmann <LW@KARO-electronics.de> wrote:
> commit c51d0ac59f24 ("mtd: nand: Move Samsung specific init/detection
> logic in nand_samsung.c") introduced a regression for Samsung SLC NAND
> chips by skipping the initialization of chip->bits_per_cell that is
> done in nand_decode_ext_id() from which the manufacturer dependent
> code was extracted.
> The regression should also affect Hynix and Macronix chips whose code
> was separated out in further commits but which I cannot test.
> AMD/Spansion and Toshiba NAND are not affected, since they are calling
> nand_decode_ext_id() (which initializes bhip->bits_per_cell) in their
> .detect function.
>
> Fix the regression and add a warning to nand_is_slc() to prevent
> further regressions of this kind.
Applied both to nand/next and generated a new PR to push this in 4.14.
Also added the Fixes and Cc-stable tag to the first patch.
Thanks,
Boris
prev parent reply other threads:[~2017-08-31 11:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 10:17 [PATCH 0/2] mtd: nand: fix regression introduced by splitting off manufacturer dependent code Lothar Waßmann
2017-08-29 10:17 ` [PATCH 1/2] mtd: nand: make Samsung SLC NAND usable again Lothar Waßmann
2017-08-29 12:16 ` Boris Brezillon
2017-08-29 13:18 ` Lothar Waßmann
2017-08-29 13:41 ` Boris Brezillon
2017-08-29 14:34 ` Lothar Waßmann
2017-08-29 10:17 ` [PATCH 2/2] mtd: nand: complain loudly when chip->bits_per_cell is not correctly initialized Lothar Waßmann
2017-08-31 11:18 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170831131836.777aa652@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=LW@KARO-electronics.de \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox