From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751987AbdHaQdm (ORCPT ); Thu, 31 Aug 2017 12:33:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:33742 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751623AbdHaQdl (ORCPT ); Thu, 31 Aug 2017 12:33:41 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FEF721978 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Thu, 31 Aug 2017 13:33:35 -0300 From: Arnaldo Carvalho de Melo To: Jack Henschel Cc: Peter Zijlstra , Ingo Molnar , Alexander Shishkin , linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf tools: Fix syntax in documentation of intel-pt config option Message-ID: <20170831163335.GF4831@kernel.org> References: <20170831080535.2157-1-jackdev@mailbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170831080535.2157-1-jackdev@mailbox.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Aug 31, 2017 at 10:05:35AM +0200, Jack Henschel escreveu: > As specified in tools/perf/Documentation/perf-config.txt, perf > configuration items must be in 'key = value' format, otherwise the > following error message occurs: > > $ perf record -e intel_pt//u -- ls > bad config file line 2 in ~/.perfconfig > $ cat .perfconfig > [intel-pt] > mispred-all > > Changing assigning a value to the key 'mispred-all' fixes the issue: > $ perf record -e intel_pt//u -- ls > [ perf record: Woken up 1 times to write data ] > [ perf record: Capured and wrote 0.031 MB perf.data] > $ cat .perfconfig > [intel-pt] > mispred-all = true You forgot to add your: Signed-off-by: Jack Henschel I'm assuming you intended it, so I'm adding it to my local repository, please ack this. - Arnaldo > --- > tools/perf/Documentation/intel-pt.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/Documentation/intel-pt.txt b/tools/perf/Documentation/intel-pt.txt > index 4b6cdbf8f935..a47d845b9b61 100644 > --- a/tools/perf/Documentation/intel-pt.txt > +++ b/tools/perf/Documentation/intel-pt.txt > @@ -873,7 +873,7 @@ amended to take the number of elements as a parameter. > > $ cat ~/.perfconfig > [intel-pt] > - mispred-all > + mispred-all = on > > $ perf record -e intel_pt//u ./sort 3000 > Bubble sorting array of 3000 elements > -- > 2.14.1