From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751109AbdIAEaJ (ORCPT ); Fri, 1 Sep 2017 00:30:09 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:33018 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbdIAEaI (ORCPT ); Fri, 1 Sep 2017 00:30:08 -0400 X-Google-Smtp-Source: ADKCNb475WcgY/9cixAkeZRzy76MdBQW85DX+WV8LXokngHFcrqCVr5j9MeqieaoBSipd+bci6v2RA== From: Nicholas Piggin To: "Rafael J. Wysocki" , Daniel Lezcano Cc: Nicholas Piggin , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner Subject: [PATCH] cpuidle: fix broadcast control when broadcast can not be entered Date: Fri, 1 Sep 2017 14:29:56 +1000 Message-Id: <20170901042956.29594-1-npiggin@gmail.com> X-Mailer: git-send-email 2.13.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When failing to enter broadcast timer mode for an idle state that requires it, a new state is selected that does not require broadcast, but the broadcast variable remains set. This causes tick_broadcast_exit to be called despite not having entered broadcast mode. This causes the WARN_ON_ONCE(!irqs_disabled()) to trigger in some cases. It does not appear to cause problems for code today, but seems to violate the interface so should be fixed. Signed-off-by: Nicholas Piggin --- drivers/cpuidle/cpuidle.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c index 60bb64f4329d..4453e27f855e 100644 --- a/drivers/cpuidle/cpuidle.c +++ b/drivers/cpuidle/cpuidle.c @@ -208,6 +208,7 @@ int cpuidle_enter_state(struct cpuidle_device *dev, struct cpuidle_driver *drv, return -EBUSY; } target_state = &drv->states[index]; + broadcast = false; } /* Take note of the planned idle state. */ -- 2.13.3