From: Joerg Roedel <joro@8bytes.org>
To: Suman Anna <s-anna@ti.com>
Cc: iommu@lists.linux-foundation.org,
Tony Lindgren <tony@atomide.com>, Tero Kristo <t-kristo@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iommu/omap: Add support to program multiple iommus
Date: Fri, 1 Sep 2017 12:01:41 +0200 [thread overview]
Message-ID: <20170901100141.2ooccy7ns2fwxceg@8bytes.org> (raw)
In-Reply-To: <20170831131402.29502-3-s-anna@ti.com>
Hi Suman,
On Thu, Aug 31, 2017 at 08:14:02AM -0500, Suman Anna wrote:
> The OMAP IOMMU driver has been enhanced to support allowing
> multiple IOMMUs to be programmed by a single client user. This
> support is being added mainly to handle the DSP subsystems on
> the DRA7xx SoCs, which have two MMUs within the same subsystem.
> These MMUs provide translations to a processor core port and
> an internal EDMA port. This support allows both the MMUs to
> be programmed together, but with each one retaining it's own
> internal state objects. The internal EDMA is managed by the
> software running on the DSPs, and this design provides on-par
> functionality with previous generation OMAP DSPs where the
> EDMA and the DSP core shared the same MMU.
I didn't get that from the review, so a question here: Do both MMUs show
show up in sysfs, means, do you register both of them the the core code?
Because I think with the solution implemented here, only a single,
combined MMU should be visible to iommu core code and in sysfs.
Regards,
Joerg
next prev parent reply other threads:[~2017-09-01 10:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 13:14 [PATCH 0/2] Dual MMU support for TI DRA7xx DSPs Suman Anna
2017-08-31 13:14 ` [PATCH 1/2] iommu/omap: Change the attach detection logic Suman Anna
2017-08-31 13:14 ` [PATCH 2/2] iommu/omap: Add support to program multiple iommus Suman Anna
2017-09-01 10:01 ` Joerg Roedel [this message]
2017-09-01 16:21 ` Suman Anna
2017-09-01 16:33 ` Joerg Roedel
2017-09-01 17:05 ` Suman Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901100141.2ooccy7ns2fwxceg@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux-foundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=s-anna@ti.com \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox